Cordova support about oidc-client-js

[brockallen]

I don't have time to add it, but if you figure out the deltas I am happy to help integrate the necessary changes.

[markphillips100]

I'll see what I can do.
On 25 May 2016 8:30 PM, "Brock Allen" [email protected] wrote:

I don't have time to add it, but if you figure out the deltas I am happy
to help integrate the necessary changes.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#34 (comment)

[markphillips100]

I added a pull request with changes that work for me but more than happy to take your recommendations.

[brockallen]

Yep, I took a quick look. I saw some cordova specific APIs added to the UserManager -- not sure I want that. Can we have a cordova client just replace the popup and silent objects on the settings? That way the UserManager doesn't have any cordova specific APIs. It just knows about popups and silent frames, right?

[markphillips100]

Thanks for the input. I'll make the changes today.

[brockallen]

I won't have time to look at this for another week or so. Thanks for the patience.

[markphillips100]

That's okay. I'll just use my fork for now and refactor later if necessary.
Thanks for all your good work.
On 1 Jun 2016 10:12 PM, "Brock Allen" [email protected] wrote:

I won't have time to look at this for another week or so. Thanks for the
patience.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#34 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AF8zNW0_ETLkbRuuDwHIKFbm_TDXFt3wks5qHXcogaJpZM4ImICB
.

[brockallen]

Merged and labeled as 1.1.0-beta.1. Mind testing it just to confirm it's working?

[markphillips100]

No problem. I'll test it today.
On 20 Jun 2016 4:13 AM, "Brock Allen" [email protected] wrote:

Merged and labeled as 1.1.0-beta.1. Mind testing it just to confirm it's
working?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#34 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AF8zNa1trI_FSntdjS92oSb8vNArtiIZks5qNYbXgaJpZM4ImICB
.

[markphillips100]

Looks good.

I have an Ionic/Angular client consuming signinPopup, signoutPopup and automaticSilentRenew enabled. The settings popupNavigator and iframeNavigator are given new instances of Oidc.CordovaPopupNavigator and Oidc.Cordova.IFrameNavigator.

Sign in/out and silent renew all working.

Thanks very much.

[brockallen]

Do you happen to have a minimal sample? I don't really use Cordova, and having a sample I can point people to would be incredibly helpful.

[markphillips100]

Might take me a week due to time constraints but should be able to come up with something. I'll add a link to the repo here when I'm done.

[markphillips100]

I've create a very simple demo here https://github.com/markphillips100/oidc-cordova-demo. I probably don't have much time in the short term for much else but let me know if you need anything and I'll see what I can do.

[brockallen]

So are we all set on this issue? Can we consider is resolved?

[markphillips100]

Indeed we can. I'll close it now
On 27 Jun 2016 6:15 AM, "Brock Allen" [email protected] wrote:

So are we all set on this issue? Can we consider is resolved?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#34 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AF8zNfyyb90C_XXvaYNiIKVN-D0toLUdks5qPt3LgaJpZM4ImICB
.

[brockallen]

I'm working on adding #3 -- if I can get that in soon, I'll do a formal 1.1.0 release.

[brockallen]

BTW @markphillips100 -- have you been using/testing the beta of this? is it all working well for you and sufficiently stable that you think we can release an official 1.1.0? thx

[markphillips100]

I will be using it thoroughly over the next 2 weeks. Can we wait till then
perhaps?

On 18 Jul 2016 6:42 AM, "Brock Allen" [email protected] wrote:

BTW @markphillips100 https://github.com/markphillips100 -- have you
been using/testing the beta of this? is it all working well for you and
sufficiently stable that you think we can release an official 1.1.0? thx

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#34 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF8zNXtfEhCxzFlVltH0BwqffSrM5xIeks5qWpOmgaJpZM4ImICB
.

[brockallen]

Ok, np. Ping me when you feel like it's solid from your testing.

[CesarD]

Any further information available on this? Could this be used (taking away the references to Ionic and similar) with AngularJs 1.5.x on a regular web page instead of a hybrid mobile app?

[robpaveza]

@markphillips100 Have you used Google+ authentication at all? I'm curious about if/how you've worked around the new Google+ restrictions on in-app iframes due to the new Google security policy (effective April 2017).

[markphillips100]

I haven't specifically used Google authentication. However, specifically from the Cordova support perspective, an Inappbrowser plugin is used not an iframe. Iframe is used from say a pure JavaScript client.

…

On 9 Oct. 2017 3:04 am, "Rob Paveza" ***@***.***> wrote: @markphillips100 <https://github.com/markphillips100> Have you used Google+ authentication at all? I'm curious about if/how you've worked around the new Google+ restrictions on in-app iframes due to the new Google security policy (effective April 2017). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#34 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF8zNT_8z9gjcfTbs8v2TIeVQyZMX1WNks5sqQCBgaJpZM4ImICB> .