Invoice table doesn't remove row after been deleted when there is only one row about idurar-erp-crm

[salahlalami]

@Zewenaco Thank your for report , issue fixed

[Sinharitik589]

@salahlalami its the backend issue
https://github.com/idurar/erp-crm/blob/e670d2830d08b0c0b80d884f031f50b056cb075a/controllers/middlewaresControllers/createCRUDController/listAll.js#L17-L22

Whenever no invoice is there we are sending success as false .

[Zewenaco]

Thanks for the reply, considering the code that you're mention. In my experience when an endpoint is returning a list or a pageable of element, if it's empty it should return success and the empty result. In this case, the backend return successfully ( an empty ) but yet successfully;

Should we refactor this to return another http code or just change the sucess value? WDYT?
It could be more suitable if the method return 204 in case of empty collection?

[Sinharitik589]

Thanks for the reply, considering the code that you're mention. In my experience when an endpoint is returning a list or a pageable of element, if it's empty it should return success and the empty result. In this case, the backend return successfully ( an empty ) but yet successfully;

Should we refactor this to return another http code or just change the sucess value? WDYT? It could be more suitable if the method return 204 in case of empty collection?

In my view status code is correct , succes needs to refactor as we are refferencing only succes here
https://github.com/idurar/erp-crm/blob/e670d2830d08b0c0b80d884f031f50b056cb075a/frontend/src/redux/erp/actions.js#L47-L66