initialState lost in a chain of extends about machina.js

[ifandelse]

uh oh - will check this out ASAP.

[ifandelse]

@dominicbarnes any chance you can provide a failing scenario? First pass with your example above:

[ifandelse]

@dominicbarnes One more screen shot:

[dominicbarnes]

Odd, I'm definitely having an issue here, but evidently I didn't get the reproduction steps right. I'll narrow this down asap

[ifandelse]

Hi @dominicbarnes hope things are well - just wanted to see if you figured out what the issue was?

[dominicbarnes]

Aha! I finally was able to reproduce this! It only happens when the FSM that you are creating via extend has a states object of it's own. Here's my newest spec to demonstrate the problem:

describe( "When extending instances with an initialState property", function() {
    it( "should properly set the initialState on the children FSMs", function() {
        var Base = machina.Fsm.extend({
            initialState: "hidden",
            states: {
                hidden: {}
            }
        });

        var Sub = Base.extend({
            // if the line below is commented out... the tests pass
            states: {}
        });

        var fsm = new Sub();

        expect(fsm.initialState).to.equal("hidden");
        expect(fsm.state).to.equal("hidden");
    });
});

Currently, using v0.3.7, I get the following result:

  0 passing (8ms)
  1 failing

  1) machina.Fsm When extending instances with an initialState property should properly set the initialState on the children FSMs:
     Error: expected 'uninitialized' to equal 'hidden'

[ifandelse]

Good deal - I'm going to plug this spec in and then get it fixed. Thanks!

[ifandelse]

@dominicbarnes OK - I believe I've got this resolved. When you get a sec, pull the v0.3.8 branch: https://github.com/ifandelse/machina.js/tree/v0.3.8. Your test has been added to the specs, and it's passing. I'll publish this to master & npm once I hear that it's working for you. Thanks!

[dominicbarnes]

Looks like this all works! Publish away! :D

[ifandelse]

Awesome - thanks for your patience through all of this.

[dominicbarnes]

Thank you for your patience with me as well :)

[ifandelse]

forgot to close this after I published... ;-)