pSet Properties is not working. about components

[agviegas]

Is this a duplicate of #100?

[shailendra26-siso]

Hi, pSet Properties is not working. · Issue #101 · IFCjs/components · GitHub <#101> and pSet Properties is not working. · Issue #100 · IFCjs/components · GitHub <#100> is related. Yes you can say that It is same. Shailendra Singh SISO Software’s India Pvt. Ltd. B-3/61, Safdarjung Enclave, IN-110029 Delhi, India. Contact: [phone] <http://www.siso.net/> www.siso.net From: Antonio González Viegas ***@***.***> Sent: Thursday, November 2, 2023 5:10 PM To: IFCjs/components ***@***.***> Cc: shailendra26-siso ***@***.***>; Author ***@***.***> Subject: Re: [IFCjs/components] pSet Properties is not working. (Issue #101) Is this a duplicate of #100 <#100> ? — Reply to this email directly, view it on GitHub <#101 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/A4QNQLLI3PGMP5YJIQ3YEA3YCOBCBAVCNFSM6AAAAAA3GRP7QOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJQGU3DMMBUGM> . You are receiving this because you authored the thread. <https://github.com/notifications/beacon/A4QNQLJ5SWEU27XPCPK7R2TYCOBCBA5CNFSM6AAAAAA3GRP7QOWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTKXHPJW.gif> Message ID: ***@***.*** ***@***.***> >

[agviegas]

Ok, got it. I already mentioned this in another issue, but can you please answer in Github directly instead of answering your email? Your messages are getting bigger and bigger and it might make this a bit hard to follow. We would also need a full minimal application that we can run where we can reproduce this to fix it. Thanks a lot in advance!

[HoyosJuan]

@shailendra26-siso it's a bit hard to tell what is going on in your code, but a couple of things to keep in mind:

1. In other cases you've said you're still using web-ifc-viewer. Keep in mind, web-ifc-viewer and openbim-components are not compatible between them, in other words you can't work with them interchangeably in the same codebase.
2. In openbim-components, the IFC entity types are not strings, but numbers. So, if you want to take all entities from a particular type, then you would have to find it by its type numbers (you can find that in web-ifc).
3. Once again, it's a bit hard to know what is going on in your code, but from the screenshots you have shown the error tell me you are working with a variable named t that you are not defining anywhere.

Hope this helps somehow.

[daniel-s-goncalves]

@HoyosJuan I seem to be having a similar issue to this (perhaps only related). I am not sure if you can check it out.

Even when using your App viewer (Demo), or your sample code, if I use a sample IFC like the ones from here (AC20-FZK-Haus.ifc), your platform is not able to add a New Property Set to the top-level of any object. In fact, if you force it to reload the property list, by closing and opening the UI window, it will throw this error:

9249.a39bde93b4db5cf6.js:6 Uncaught (in promise) TypeError: Cannot read properties of null (reading 'value')
    at aY.getEntityName (9249.a39bde93b4db5cf6.js:6:395616)
    at aQ.newEntityTree (9249.a39bde93b4db5cf6.js:6:423610)
    at aQ.newEntityUI (9249.a39bde93b4db5cf6.js:6:421029)
    at 0 (9249.a39bde93b4db5cf6.js:6:418216)
    at 9249.a39bde93b4db5cf6.js:6:421390
    at Y.trigger (9249.a39bde93b4db5cf6.js:1:29839)
    at set expanded [as expanded] (9249.a39bde93b4db5cf6.js:6:100764)
    at iB.toggle (9249.a39bde93b4db5cf6.js:6:101370)
    at innerElements.expandBtn.onclick (9249.a39bde93b4db5cf6.js:6:103128)

When playing around with your functions and replicating the code that is run by your UI when adding the PSET, I noticed that the expressID of the added PSET is -1 and the MAX_ID is not taken into account when doing this.

I think there's an ongoing issue with this, and I wonder if the entire property list of the IfcPropertiesManager also gets updated when the PSET is added.

[HoyosJuan]

Yes @daniel-s-goncalves! We're aware of that issue. What happens is that each time a new property is added, the "calculated" expressIDs are wrong. The solution should be easy enough I guess 💪

Will come back with more news about this.

[HoyosJuan]

This is solved in PR #214.