GithubHelp home page GithubHelp logo

[Bug]: Regression Writing "Integer" Values with writeRawLineData, superflous wrapping in ToRawLineData causes wrong value to be written about web-ifc HOT 4 CLOSED

quasarchimaere avatar quasarchimaere commented on August 30, 2024
[Bug]: Regression Writing "Integer" Values with writeRawLineData, superflous wrapping in ToRawLineData causes wrong value to be written

from web-ifc.

Comments (4)

quasarchimaere avatar quasarchimaere commented on August 30, 2024

@beachtom it might be that the issue fix introduced in the #534 was not even necessary, and the Exponent issue was solely on our end, since we created Exponents as Number and not Integer types.

from web-ifc.

beachtom avatar beachtom commented on August 30, 2024

OK let me look into this.

from web-ifc.

quasarchimaere avatar quasarchimaere commented on August 30, 2024

@beachtom Further Info: yes, my assumption was correct. there was actually no exponent issue while writing IFCDERIVEDUNITELEMENT in the first place, we simply parsed the wrong type (type: 4) into the rawLineData and thus it was written as a real value instead of an integer, switching our unitgeneration to ints (type: 10) fixes the issue within web-ifc 0.0.50 (which was the version before your fix got committed), so i assume that removing the wrapping {type: 10, value: i.XYZ} is unnecessary and can be removed again.

from web-ifc.

beachtom avatar beachtom commented on August 30, 2024

I've rolled this back. So hopefully it work now.

from web-ifc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.