GithubHelp home page GithubHelp logo

Comments (7)

tovari avatar tovari commented on September 29, 2024 1

I still see the problem at the Weekly digest emails on prod and staging.

from go-api.

szabozoltan69 avatar szabozoltan69 commented on September 29, 2024

Could not reproduce locally. It means that some kind of env variable issue exists.

Locally the notification is generated nicely:

kÊp

from go-api.

szabozoltan69 avatar szabozoltan69 commented on September 29, 2024

These '|quote' transformations are new features in https://github.com/IFRCGo/go-api/blob/terraform/deploy/helm/ifrcgo-helm/templates/config/configmap.yaml#L18-L19 – they may cause new "effects" in notification templates as well.
Do you have any quess how could we use them appropriately in e.g. https://github.com/IFRCGo/go-api/blob/terraform/notifications/templates/design/head1.html#L417 (record.resource_uri) without quotation marks? @batpad @geohacker

from go-api.

szabozoltan69 avatar szabozoltan69 commented on September 29, 2024

Root cause: settings.FRONTEND_URL contains empty string.
If I fix it, result is ok:
image
(Probably another entity is also running, where the manual change could not be seen; that other notification remained bad.)
Obsolate:
https://stackoverflow.com/questions/36954472/removing-quotes-in-a-django-template could help. But maybe it's easier to strip the variable in the moment of giving it to the renderer, in https://github.com/IFRCGo/go-api/blob/develop/api/management/commands/index_and_notify.py#L160 and similar in that script.

from go-api.

szabozoltan69 avatar szabozoltan69 commented on September 29, 2024

With giving FRONTEND_URL issue is solved.

from go-api.

tovari avatar tovari commented on September 29, 2024

Somehow the icon is still missing on all Weekly digest emails:

Image

from go-api.

szabozoltan69 avatar szabozoltan69 commented on September 29, 2024

Let me check it...

from go-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤ī¸ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.