GithubHelp home page GithubHelp logo

Comments (4)

IgnaceMaes avatar IgnaceMaes commented on August 11, 2024

Read-only properties you mean? Seems like a good idea to me, dropping the "Get" and "()" would make easier to read and less confusing when used in a complex draw method.

I'm not sure about the naming pattern, e.g. MainTextColor seems more logical to me than ColorMainText. However, with Intellisense code completion the second format would be easier to discover the right property quick.

from materialskin.

BigBauf avatar BigBauf commented on August 11, 2024

That's my thought
problem would be the GetRaisedButtonTextBrush(bool primary) method, Didn't put much thought into that yet.
If you want i can Refactor that and think about a Solution to that

from materialskin.

Tempz avatar Tempz commented on August 11, 2024

^
In my (pending) pull request (#28), I added a color manager to select a different primary and secondary color based on Google's flat color palettes. We can (maybe) add namespaces to it with say, ColorManager...<color/brush/pen>, like ColorManager.FlatButton.Something.Brush
Wait for Ignace to merge it before continuing with this.

from materialskin.

IgnaceMaes avatar IgnaceMaes commented on August 11, 2024

I merged the PR from @Tempz. However, I modified his ColorManager class into ColorScheme. Because ColorScheme is just for the variable colors, it wouldn't make sense anymore to include the constant colors there.

I think it would be a good idea to separate the constant colors from the SkinManager, or at least put them in a region.

@BigBauf making 2 separate properties would be the easiest clean solution. e.g. SkinManager(?).BrushRaisedButtonText & SkinManager(?).BrushRaisedButtonTextPrimary.

from materialskin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.