Comments (4)
Read-only properties you mean? Seems like a good idea to me, dropping the "Get" and "()" would make easier to read and less confusing when used in a complex draw method.
I'm not sure about the naming pattern, e.g. MainTextColor seems more logical to me than ColorMainText. However, with Intellisense code completion the second format would be easier to discover the right property quick.
from materialskin.
That's my thought
problem would be the GetRaisedButtonTextBrush(bool primary) method, Didn't put much thought into that yet.
If you want i can Refactor that and think about a Solution to that
from materialskin.
^
In my (pending) pull request (#28), I added a color manager to select a different primary and secondary color based on Google's flat color palettes. We can (maybe) add namespaces to it with say, ColorManager...<color/brush/pen>, like ColorManager.FlatButton.Something.Brush
Wait for Ignace to merge it before continuing with this.
from materialskin.
I merged the PR from @Tempz. However, I modified his ColorManager class into ColorScheme. Because ColorScheme is just for the variable colors, it wouldn't make sense anymore to include the constant colors there.
I think it would be a good idea to separate the constant colors from the SkinManager, or at least put them in a region.
@BigBauf making 2 separate properties would be the easiest clean solution. e.g. SkinManager(?).BrushRaisedButtonText & SkinManager(?).BrushRaisedButtonTextPrimary.
from materialskin.
Related Issues (20)
- Screen resolutions not 100%
- MaterialTextBox "Password" Attribute is strange
- Mainform crashed when using Password Property HOT 2
- window 7 process
- Drawer does not show icons HOT 3
- MaterialSnackBar TopMost issue HOT 1
- How do I enable or disable (Show or Hide) a specific tabpage in a MaterialTabControl ?
- Textbox with Korean Char is not correctly entered
- MultiLineTextBox line wrapping and text appending
- TabSelector and TabPages
- Modify border style for drop shadow
- Setting TabControl Alignment property to left or right doesn't affect tab selector position.
- Font size can not be changed,字体大小不能更改 HOT 1
- Timers not allowed on forms with MaterialSkin.2? HOT 2
- Maximize on Second Monitor Goes Off Screen
- Save UI settings HOT 1
- MaterialSkin and MaterialSkin.2 Torjan (Wacatac.H!ml) HOT 1
- Font issue on foreign computers HOT 1
- How to write in a combobox HOT 3
- Save Click Event Handler in Expansion Panel.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from materialskin.