it throws a deprecation warning : Slash as Division about compass-mixins

[blaiz]

Here's a PR written by my coworker that fixes the current issue

[blaiz]

We're having the exact same issue here. We were able to fix all the instances in our own code by wrapping divisions with calc() but we can't fix the warnings related to compass-mixins since it's in node_modules. Could the fix be as simple as wrapping those in calc()? I could open a PR if that's the case.

[hiratsuka-r]

@blaiz
Thank you for your comment.

Could the fix be as simple as wrapping those in calc ()?

Yes, that's right. The official page also says:

This deprecation does not affect uses of / inside calc () expressions.

Alternatively, users can wrap division operations inside a calc() expression, which Sass will simplify to a single number.
// WRONG, will not work in future Sass versions.
@debug (12px/4px); // 3

// RIGHT, will work in future Sass versions.
@debug calc(12px / 4px); // 3

https://sass-lang.com/d/slash-div
We apologize for the inconvenience, but we would be grateful if you could fix it.

[hiratsuka-r]

I got the following warning:

Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

32 │ $base-rhythm-unit: $base-line-height / $base-font-size * $font-unit;
   │                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    node_modules/compass-mixins/lib/compass/typography/_vertical_rhythm.scss 32:20  @import


36 │ $base-leader: ($base-line-height - $base-font-size) * $font-unit / $base-font-size;
   │               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    node_modules/compass-mixins/lib/compass/typography/_vertical_rhythm.scss 36:15  @import


40 │ $base-half-leader: $base-leader / 2;
   │                    ^^^^^^^^^^^^^^^^
    node_modules/compass-mixins/lib/compass/typography/_vertical_rhythm.scss 40:20  @import


120 │   $rhythm: $font-unit * ($lines * $base-line-height - $offset) / $font-size;
    │            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    node_modules/compass-mixins/lib/compass/typography/_vertical_rhythm.scss 120:12  rhythm()

Maybe there are other things I missed.
I'm not confident ..., but I also get the source and are looking for parts to repair.

[Igosuki]

Could you please submit a PR with the changes ? Thanks

[blaiz]

Will do.

…

On Sun, May 22, 2022, 00:22 Guillaume Balaine ***@***.***> wrote: Could you please submit a PR with the changes ? Thanks — Reply to this email directly, view it on GitHub <#121 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMK6Z5WHLC7XPPPA27SSLTVLHODFANCNFSM5WDXRMKA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[hiratsuka-r]

I don't get any warnings at hand.

Pushing to github.com:Igosuki/compass-mixins.git
ERROR: Permission to Igosuki/compass-mixins.git denied to hiratsuka-r.
fatal: Could not read from remote repository.

Please add to the team with write access to the repository.
↑ It doesn't matter if it's temporary.

[hiratsuka-r]

@blaiz @SiriVadlapudi
I'm sorry it took a long time
Thank you for the fix! I checked the contents of the pull request.

There was only one difference from what I fixed. I made a comment.
Please check them when you have time.