Tests for abspath don't pass on Windows about pystring

[lgritz]

I'm embarrassed to say that this project has not had any reported bugs or patches offered for 5+ years (that's a strength, right?), and now nobody who had previously contributed to this project is still at SPI. We use it a lot, but so thoroughly take for granted its stability that there's nobody specifically assigned to it, nor easily identified as knowing about the internals. So our mechanism for dealing with reported problems is rusty, to say the least.

If you have a proposed fix, please do submit a PR -- including an appropriate test in test.cpp if this case is not already covered -- and I will merge the patch and tag a release.

[wrosecrans]

Haha, no worries. I understand. (I only hope I ever write something that nobody runs into a bug after five years of use. For some reason, my own projects always seem to retain very recent organisational memory about such things!)

If I make a PR, would I need to sort out a CLA?

Would you take a PR that adds a CMakeLists.txt for building on non-gcc?

[lgritz]

Yes, sorry, CLAs are necessary to merge any code. It's practically the only constraint placed on our open source projects by the corporate overlords, so we feel obligated to be strict with that rule.

Yes, a CMake build system would be welcome. Somebody else also pointed out that the whole thing needs a generous sprinkling of 'const' if we really want to be modern and helpful.

We do continue to use pystring extensively internally, it's by no means abandoned... just that no change had been needed for so long that we kind of didn't notice that none of the original caretakers were still at the company. But I think we've identified somebody here who can continue to shepherd this project.

[wrosecrans]

Gotcha. My employer is also pretty open source friendly, but there is a process for CLA review. I submitted an internal request for approval, but it may be a little bit before that gets sorted out. Sometimes the corporate wheels turn slowly.

And then I actually have to make time to sit down and write a PR.

[grdanny]

This has been addressed in PR #23
I tested it on our end on both windows and linux, so it should be fine, but do let me know if anything looks strange on your end.

Thanks!