GithubHelp home page GithubHelp logo

Comments (6)

paulstraw avatar paulstraw commented on July 17, 2024

Interesting. Just so I'm 100% sure we're on the same page, could you send through example input and output URLs?

from imgix-swift.

jndonald3 avatar jndonald3 commented on July 17, 2024
let imageUrl = imgixClient.reconstruct(withURL: NSURL(string: "http://images.domain.com/default.png")!, params: ["auto":"format,compress"])
// imageUrl = "http://images.domain.com/default.png?auto=format%2Ccompress&ixlib=swift-0.1.2"

from imgix-swift.

paulstraw avatar paulstraw commented on July 17, 2024

What would happen to the NSURL's query string in this case, if present? Also, would duplicate values be overridden?

from imgix-swift.

jndonald3 avatar jndonald3 commented on July 17, 2024

The original query string should be joined with new parameters.
I'd say that since the developer is supplying the imgix parameter dictionary, its fine to overwrite them from the original query string.

You could also just provide a flag for that issue to make it more flexible.

from imgix-swift.

paulstraw avatar paulstraw commented on July 17, 2024

Hey @jndonald3, if possible, would you mind giving #8 a shot and letting me know if that works nicely for you? Thanks!

from imgix-swift.

paulstraw avatar paulstraw commented on July 17, 2024

Alrighty, released as 0.3.0!

from imgix-swift.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.