invalid TIFF format: image dimensions are not specified about imgproxy

[DarthSim]

Hey everyone!

Thanks for the sample! Should be fixed in the latest build.

[dbackeus]

We're also getting this error for quite a few tiff files.

Here is an example: https://drive.google.com/file/d/1mgyZP-loct-gKEzY0FVuvTy262AoWhhO/view?usp=sharing

Running vipsheader on it I get:
hwop6cu3s5ljmpmwabfe.tiff: 1549x933 uchar, 4 bands, cmyk, tiffload

Which appears to include the dimensions. Also MacOS preview can load the tiff just fine and it was possible to transform it on our previous asset hosting Cloudinary.

[dbackeus]

Oddly, when I tried adding a test for one of the broken tiffs on my MacBook it parsed the tiff just fine.

package imagemeta

import (
	"os"
	"path/filepath"
	"testing"

	"github.com/imgproxy/imgproxy/v3/imagetype"
	"github.com/stretchr/testify/require"
	"github.com/stretchr/testify/suite"
)

type TiffTestSuite struct {
	suite.Suite
}

func (s *TiffTestSuite) openFile(name string) *os.File {
	wd, err := os.Getwd()
	require.Nil(s.T(), err)
	path := filepath.Join(wd, "..", "testdata", name)
	f, err := os.Open(path)
	require.Nil(s.T(), err)
	return f
}

func (s *TiffTestSuite) TestDecodeTiffMeta1() {
	f := s.openFile("not-working.tiff")
	defer f.Close()

	metadata, err := DecodeTiffMeta(f)
	require.Nil(s.T(), err)
	require.Equal(
		s.T(),
		&meta{
			format: imagetype.TIFF,
			width:  213,
			height: 185,
		},
		metadata,
	)
}

func TestTiff(t *testing.T) {
	suite.Run(t, new(TiffTestSuite))
}

I also tried going through the whole processing pipeline via processing_handler_test.go which also didn't fail:

func (s *ProcessingHandlerTestSuite) TestTiffRequest() {
	rw := s.send("/unsafe/rs:fill:4:4/plain/local:///not-working.tiff")
	res := rw.Result()

	require.Equal(s.T(), 200, res.StatusCode)
	require.Equal(s.T(), "image/png", res.Header.Get("Content-Type"))

	meta, err := imagemeta.DecodeMeta(res.Body)

	require.Nil(s.T(), err)
	require.Equal(s.T(), imagetype.PNG, meta.Format())
	require.Equal(s.T(), 4, meta.Width())
	require.Equal(s.T(), 4, meta.Height())
}

Could this error be environment specific somehow?

We're running the imgproxy-pro:latest-ml container in Kubernetes via Talos Linux.

[dbackeus]

Just deployed the latest version.

So far so good 🙌

[dbackeus]

Can confirm no TIFF errors logged since the deploy 7 hours ago 🕺

[mstaack]

confirmed..no issues since deploy :)
thanks