Comments (16)
Thanks for letting us know. There was a similar request and I think the goal was to automatically update them in each run of paq.sh
/paq.bat
(i.e. during the "amalgamation" process). PRs are welcome and because it sounds like an easy to review change, they'll be merged very quickly (couple of days probably).
from nuklear.
I was going to push to a new branch, but I don't seem to be able to do that. So I'm attaching the modified 'src/nuklear_font.h'.
NOTE: There are two functions which in the current version take an nk_allocator, but which have no such thing in the code I merge; I do not understand all the ramifications of not having the allocator, it seems to work as-is on my Linux box.
The functions in question are part of the baker:
- nk_tt_PackFontRangesRenderIntoRects
- nk_tt_PackEnd
from nuklear.
The code does crash on macOS, so apparently the allocator is needed. I was hoping it might be possible to allocate whatever's needed beforehand rather than piecemeal. But I don't know the code, and am relying on you guys.
from nuklear.
Still relying on you guys... any feedback on the need for the allocator?
from nuklear.
I'm still out of time to do reviews. But what caught my eye is that you can't submit a PR - that's weird. Could you please try again (step by step as GitHub doc says)? It would encourage others to look over your changes 😉.
from nuklear.
Pinging again, since I put a PR in just after your last comment. Looking for assistance on that issue, since the ancient TTF support is hindering me.
from nuklear.
@Nielsbishere feel free to review the PR - I'd like to give you commit permission afterwards 😉
from nuklear.
@ronaaron Someone shares my pain <3
I have been bothered by the old stb_library versions myself. Many thanks for for the PR and the contribution!
from nuklear.
Yeah; I hope it gets integrated (with appropriate changes) soon.
from nuklear.
stb_truetype update request appeared several times also in the old Nuklear repo. I think we should move away from making changes to stb_truetype once and forever. Could you @ronaaron change your PR in a way, that there is separate stb_truetype.h
taken 1:1 from the stb repo and then in src_nuklear_font.c
there'll be just the Nuklear-specific stuff? It'll be also easier to review 😉 (and I think I'll review it despite my lack of time because of the high demand).
@SairesArt would you want to review the PR (or other PRs)? This would help the project a lot (I'd then give you commit permission 😉).
from nuklear.
that there is separate
stb_truetype.h
taken 1:1 from the stb repo
That sounds like a good quality of life quality of code change for future updates, which ideally should have been done from the get go. So @ronaaron is unknowingly kicking off some important code refactoring :P
@SairesArt would you want to review the PR (or other PRs)? This would help the project a lot (I'd then give you commit permission wink).
I was very pleasantly surprised to find nuklear changing repos and being revived again, after some slumber during the past two years. Contributing to nuklear has been on my todo list for quite some time (GLFW OpenGL ES2 demo and ideally an option for SDF text rendering), but never came around to it... so I'll gladly take you up on that offer. Whilst I'm at it, I'll make a fresh new github account (another todo thing), message you this evening for the permissions and review me some PR's this weekend :]
from nuklear.
So I just uploaded a modified version of my ttf branch, which separates both stb files. I had to also play a bit with the packer so that I could get the STB*IMPLEMENTATION if NK_IMPLEMENTATION is defined.
I left two "TODO" comments in the code, where I am not sure what to do.
from nuklear.
@SairesArt Here with my new Account to tackle all my Open Source responsibilities :]
@dumblob Although a bit late, I'd love to get commit rights and go through the backlog of PRs now.
from nuklear.
@SairesArt Here with my new Account
@FrostKiwi Quick proof of ownership via quote reply
Welp, so much for "this weekend". Life decided to head a couple more stuff my way, but now I can take on some PRs^^
from nuklear.
@FrostKiwi greetings and thanks for your interest. Could you please find the culprit for the last unsolved issue described in #53 (comment) ? Then I'll merge the PR and you'll get the commit rights 😉.
from nuklear.
I think this can be closed as the PR #53 got merged. Feel free to reopen if you feel so.
from nuklear.
Related Issues (20)
- Backspace does not actually clear a buffer when using nk_edit_string HOT 4
- File Menu HOT 6
- Request: create example for showcasing integration with RGFW HOT 2
- How to make own title bar, without using the operating systems HOT 3
- Group margins/alignment Ubuntu HOT 3
- Demo doesn't include code on how to display images without OpenGL. HOT 1
- After set an opened Combo Box to invisible, no response from the entire window.
- How to do multiple render with one update HOT 2
- Events not working with multiple Nuklear windows
- Add `delta_time_seconds` to each renderer
- GUI "cards" HOT 6
- Multiple window instances HOT 2
- Inputs propagating to windows in background HOT 1
- No documentation explaining how to convert an nk_rune to a char. HOT 1
- Fragment shader used in the GLFW GL4 wrapper doesn't compile
- Getting some strange text clipping behavior when dragging windows around. HOT 1
- prefilling and updating an nk_edit_string while allowing manual editing ?
- 2 errors HOT 2
- Can`t assemble from src in msvs win HOT 2
- feature request: extend NO_SCROLLBAR with horizontal/vertical options HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nuklear.