GithubHelp home page GithubHelp logo

Comments (8)

kdreher avatar kdreher commented on May 29, 2024

We should implement default illumination and detection devices separately and an additional PA device generator that takes one illumination and one detection device from our predefined devices and generates the respective PA device.
This way, users have a lot more choices to construct a PA device "on the fly". Also, it is more elegant to just simulate the optical or acoustic models without having to choose a PA device when there is no PA effect involved.

Specific products like the MSOT devices can still stay the way they are.

from simpa.

jgroehl avatar jgroehl commented on May 29, 2024

It might be worth considering creating new classes for the DetectionGeometry and IlluminationGeometry and having a PADevice class that is a combination of the two?
The settings file would then be assigned the PADevice instance, where one of the two could be None thus achieving what you propose?

from simpa.

jgroehl avatar jgroehl commented on May 29, 2024

Potentially found an "off-by-one" error in the Python to MATLAB conversion when defining the detector positions. MATLAB indexing starts with 1, not 0, which we apparently did not consider previously.

from simpa.

jgroehl avatar jgroehl commented on May 29, 2024

Work on this will also fix #49.

from simpa.

jgroehl avatar jgroehl commented on May 29, 2024

Linear and curved detection geometries are now implemented.

from simpa.

jgroehl avatar jgroehl commented on May 29, 2024

Implemented all previously available devices.
Custom devices that combine the illumination and detection geometries can now easily be added.

@kdreher I propose we discuss the current implementation, integrate it into develop and start adding more detection and illumination geometries in a new task.

from simpa.

jgroehl avatar jgroehl commented on May 29, 2024

Will work towards #11, #19, and #12 within these changes.

from simpa.

jgroehl avatar jgroehl commented on May 29, 2024

Opened new task #61 for the addition of further geometries that should be in SIMPA.
Closing, as it is integrated in #57

from simpa.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.