Confusing caveat in SSH section about how-to-secure-a-linux-server

SSH is not resilient to MITM attacks. mitmproxy is an example of a tool that claims to be able to intercept such a connection. Of course, if you don't trust the server you're copying your key to, you shouldn't do it in the first place. SSH should also warn you about potential MITM attacks if the fingerprint changes from when you first connected to the server.

Regarding the rest of your question, you may find Is there any risk from attempting ssh authentication to a rogue server? interesting. Depending on your threat model, simply authenticating with a rogue server shouldn't pose any risk. You should probably open a PR to clarify the language.

[imthenachoman]

I've read many debates on the public key. Yes, it is public, but that doesn't mean you want anyone to have it. Public or not, everything should be need-to-know, right?

I have gotten other comments on that line though. Maybe I should remove it?

[imthenachoman]

I got other feedback on that one line. I changed it. Hopefully its more clear now.