Comments (5)
I just used the MSRV (1.18) cargo when publishing 1.3.1, which doesn't rewrite Cargo.toml
-- that was introduced in rust-lang/cargo#4030, cargo 0.20.0 (Rust 1.19).
This seems like a pretty serious regression, and is likely to be a substantial impediment to all linux vendors packaging rust.
I think you're overstating the severity. The crates.io package is not broken when used as a normal dependency, and the missing workspace only matters when you try to use it as a primary source. I happen to be a Fedora packager too, and I just patched it out there:
https://src.fedoraproject.org/rpms/rust-indexmap/blob/314395ffa87c370a0ef2bdcc41e7ebddc034beff/f/indexmap-fix-metadata.diff#_18
As a linux vendor, you should already be prepared to make such changes for any crate that was packaged before Cargo.toml
rewriting started.
Still, I will make a new release...
from indexmap.
I feel wary of publishing with newer Cargo than MSRV, in case its Cargo.toml
rewriting ever does something that's not supported by older Cargo. However, I'm not aware of any such problems yet.
from indexmap.
I think you're overstating the severity.
Indeed, after filing the bug I found it was easier to patch out than I'd anticipated.
Though thanks for making a new release anyway, where possible, we desire to follow upstream with as few patches as possible :)
from indexmap.
I just used the MSRV (1.18) cargo when publishing 1.3.1,
@cuviper Is it important to package like this? Just curious why you've included this in your process.
from indexmap.
I feel wary of publishing with newer Cargo than MSRV, in case its
Cargo.toml
rewriting ever does something that's not supported by older Cargo. However, I'm not aware of any such problems yet.
Only problem I'm aware of is the new Cargo.lock layout getting shipped, which doesn't parse with older cargo, but you'll only have that if you ship examples or binaries.
from indexmap.
Related Issues (20)
- `binary_search` and `partition_point` on `Slice` HOT 4
- Feature request: Add Index<usize> to Keys HOT 1
- Implement (behind a feature branch) the Merge Crate HOT 4
- IndexMap doesn't implement `Hash` HOT 1
- Compilation bug HOT 1
- Organization / repo home HOT 12
- Doc link on crates.io is dead. HOT 3
- Kaspersky detected the indexmap build-script exe as malware (false positive) HOT 1
- MutableKeys for IndexSet HOT 2
- implement get_many_mut HOT 1
- serde_json::to_string serializes (key, value) HOT 3
- Request: add example to README
- Thanks :)
- Insert into Indexmap randomly fails HOT 9
- Expanding mut key API HOT 2
- Feature request: join two or more IndexMap HOT 2
- Request: Random access of key/value pairs HOT 2
- range end index 2 out of range for slice of length 1 HOT 20
- Feature request: `Into<std::collections::HashMap>` HOT 1
- `Clone` for into-iterators HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from indexmap.