GithubHelp home page GithubHelp logo

Comments (5)

cuviper avatar cuviper commented on September 26, 2024 1

I just used the MSRV (1.18) cargo when publishing 1.3.1, which doesn't rewrite Cargo.toml -- that was introduced in rust-lang/cargo#4030, cargo 0.20.0 (Rust 1.19).

This seems like a pretty serious regression, and is likely to be a substantial impediment to all linux vendors packaging rust.

I think you're overstating the severity. The crates.io package is not broken when used as a normal dependency, and the missing workspace only matters when you try to use it as a primary source. I happen to be a Fedora packager too, and I just patched it out there:
https://src.fedoraproject.org/rpms/rust-indexmap/blob/314395ffa87c370a0ef2bdcc41e7ebddc034beff/f/indexmap-fix-metadata.diff#_18

As a linux vendor, you should already be prepared to make such changes for any crate that was packaged before Cargo.toml rewriting started.

Still, I will make a new release...

from indexmap.

cuviper avatar cuviper commented on September 26, 2024 1

I feel wary of publishing with newer Cargo than MSRV, in case its Cargo.toml rewriting ever does something that's not supported by older Cargo. However, I'm not aware of any such problems yet.

from indexmap.

kentfredric avatar kentfredric commented on September 26, 2024

I think you're overstating the severity.

Indeed, after filing the bug I found it was easier to patch out than I'd anticipated.

Though thanks for making a new release anyway, where possible, we desire to follow upstream with as few patches as possible :)

from indexmap.

bluss avatar bluss commented on September 26, 2024

I just used the MSRV (1.18) cargo when publishing 1.3.1,

@cuviper Is it important to package like this? Just curious why you've included this in your process.

from indexmap.

kentfredric avatar kentfredric commented on September 26, 2024

I feel wary of publishing with newer Cargo than MSRV, in case its Cargo.toml rewriting ever does something that's not supported by older Cargo. However, I'm not aware of any such problems yet.

Only problem I'm aware of is the new Cargo.lock layout getting shipped, which doesn't parse with older cargo, but you'll only have that if you ship examples or binaries.

from indexmap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.