Astrometry driver crashes when CCD frame is compressed about indi

[TallFurryMan]

Actually I need an advice here: function dispatch() in indidriver is sending the size, not the encoded length.

The problem might be deeper than I think: when the dispatched blob is compressed, it is indidriver which needs fixing, not the Astrometry driver.

There could be many side-effects if I change indidriver.c:1173 to use attribute enclen instead of size, but I think this is how it should work.

[TallFurryMan]

I got it wrong on where the error was for this exact issue, as this issue relates to a snooped device, still digging.
But the fact remains that there is a bug at indidriver.c:1173.

[knro]

Oh I actually recall this issue. It was on my TODO list when I was making the astrometry driver. I encountered many issues when developing the astrometry driver related to how BLOBs are transferred between drivers and fix most of them, but then I didn't proceed to uncompress the blob before sending it off to the driver.

…

On Wed, Mar 29, 2017 at 4:01 PM, TallFurryMan ***@***.***> wrote: Actually I need an advice here: function dispatch() in indidriver is sending the size, not the encoded length. The problem might be deeper than I think: when the dispatched blob is compressed, it is indidriver which needs fixing, not the Astrometry driver. There could be many side-effects if I change indidriver.c:1173 to use attribute enclen instead of size, but I think this is how it should work. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#194 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFtYK2QakWj6xJ2nNAPatJ4l-xjUf1fEks5rqlY2gaJpZM4Ms774> .

-- Best Regards, Jasem Mutlaq

[knro]

actually, after investigating the code a bit. I think it is better to send blobs as is to the drivers and not assume they want to uncompress them. Therefore, the astrometry driver should uncompress. I'll work on that. On Wed, Mar 29, 2017 at 4:21 PM, Jasem Mutlaq <[email protected]> wrote:

…

Oh I actually recall this issue. It was on my TODO list when I was making the astrometry driver. I encountered many issues when developing the astrometry driver related to how BLOBs are transferred between drivers and fix most of them, but then I didn't proceed to uncompress the blob before sending it off to the driver. On Wed, Mar 29, 2017 at 4:01 PM, TallFurryMan ***@***.***> wrote: > Actually I need an advice here: function dispatch() in indidriver is > sending the size, not the encoded length. > > The problem might be deeper than I think: when the dispatched blob is > compressed, it is indidriver which needs fixing, not the Astrometry driver. > > There could be many side-effects if I change indidriver.c:1173 to use > attribute enclen instead of size, but I think this is how it should work. > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#194 (comment)>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AFtYK2QakWj6xJ2nNAPatJ4l-xjUf1fEks5rqlY2gaJpZM4Ms774> > . > -- Best Regards, Jasem Mutlaq

-- Best Regards, Jasem Mutlaq

[TallFurryMan]

Fixed by b820215