Preparing for 0.0.6 release about ggstatsplot

[ibecav]

A quick update. I've managed to cut the file size in about half so far and hopefully also make things clearer but won't be able to finish until tomorrow.

[ibecav]

Absolutely I’ll get to those Monday, my plan is to go through all of them but I’ll start with those. Good idea on 200 dpi Sent from my mobile please forgive my brevity

…

On Sep 28, 2018, at 22:34, Indrajeet Patil ***@***.***> wrote: In addition to the vignette changes you have made, I've also tidied up the README file a bit and also reduced dpi for all vignettes to 200, which should reduce the size of figures to some degree. The vignette build time has now been reduced (~ 5 min). But the size the package is slightly above limit (6.3 MB). I think CRAN will accept it, but we should still attempt to reduce a bit further. I was thinking of re-submitting the package on the 30th. If you get time, do you also mind having a look at ggbetweenstats (or purrr_examples) vignette? They are the largest and most time-consuming vignettes right now. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[ibecav]

If you don't mind, I'll take on the two following tasks and submit a PR (one at a time) in the order stated.

1. Cleanup all the warning messages generated in a full CRAN build, e.g. "Warning: @description [/Users/cpowell/Documents/RProjects/ggstatsplot/R/helpers_ggbetween_subtitles.R#1]: requires a value" which are simply about blank comment lines in some places.

2. I'll take a look at the vignettes to see what I can find to make them smaller and more performant.

Chuck

[IndrajeetPatil]

Hi Chuck,

1. Sure, you can have a look at this. But this is not really a problem because R CMD CHECK doesn't have any problems with these (you'll see that if you run devtools::check()). This seems to be associated with #' in roxygen2 documentation with trailing white spaces when devtools::document(roclets=c('rd', 'collate', 'namespace')) is used (r-lib/roxygen2#710).
2. Yes, but I think it will not be prudent to downsize vignettes without adding more tests in testthat. That's why I haven't really made it a priority for the next release (0.0.6). CRAN is a bit more lenient with the size of the package (> 5MB) if you can justify it. But, yes, as a long-term goal, I do want to reduce their size. Do you also want to have a look at the tests and see if you can add more tests?

[ibecav]

I submitted #1 as a PR. I want to look at the vignettes for several reasons. No expertise on testthat but I'll see what I cam learn.

[IndrajeetPatil]

Hi Chuck,

I have added you as a contributor to the package. Also, I will be pushing the new version (0.0.6) of the package to CRAN on the 26th. There is a lot of new functionality I had added since 0.0.5 that I no longer want to postpone from pushing to CRAN.

So if you wanted to add something new, you can create a PR, but depending on when the package makes it to CRAN, it will either be part of the next release (0.0.6) or next to next (0.0.7).

[ibecav]

Okay thanks. I'm currently looking at gghistostats.Rmd where I've hit some substantive challenges. About the only thing I may and try and PR in he next day or so is this one.

…

On Mon, Sep 24, 2018 at 2:45 PM Indrajeet Patil ***@***.***> wrote: Hi Chuck, I have added you as a contributor to the package. Also, I will be pushing the new version (0.0.6) of the package to CRAN on the 26th. There is a lot of new functionality I had added since 0.0.5 that I no longer want to postpone from pushing to CRAN. So if you wanted to add something new, you can create a PR, but depending on when the package makes it to CRAN, it will either be part of the next release (0.0.6) or next to next (0.0.7). — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#44 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AZU62dg7Rwk3J7OdQtYvNhUXlPMnlqQXks5ueShFgaJpZM4Wpkty> .

[IndrajeetPatil]

@ibecav Unfortunately, the package was rejected by CRAN because the size is larger than 5 MB and the vignette build-up time is ~ 10 minutes (and they need it to be around 5 minutes).
So I think is something that needs to be resolved before next submission.

Do you mind having a look at the vignette for ggpiestats? I think it can use some fine-tuning.

I will be removing plot_design vignette, which wasn't really supposed to be included anyway. I plan to publish it somewhere else (like a blog post).

[ibecav]

Happy to look this aft. My favorite place to post is Rbloggers see for example https://www.r-bloggers.com/announcing-another-slopegraph-plotting-function-june-14-2018/ I haven't pinned it down completely yet but I think a lot of the issue with the vignettes is just that ggplot objects tend to be big even if the dataset isn't huge.

…

On Thu, Sep 27, 2018 at 9:20 AM Indrajeet Patil ***@***.***> wrote: @ibecav <https://github.com/ibecav> Unfortunately, the package was rejected by CRAN because the size is larger than 5 MB and the vignette build-up time is ~ 10 minutes (and they need it to be around 5 minutes). So I think is something that needs to be resolved before next submission. Do you mind having a look at the vignette for ggpiestats? I think it can use some fine-tuning. I will be removing plot_design vignette, which wasn't really supposed to be included anyway. I plan to publish it somewhere else (like a blog post). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#44 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AZU62TInRsza2oBJSRiKb526VGnNtQIBks5ufNCFgaJpZM4Wpkty> .

[IndrajeetPatil]

In addition to the vignette changes you have made, I've also tidied up the README file a bit and also reduced dpi for all vignettes to 200, which should reduce the size of figures to some degree. The vignette build time has now been reduced (~ 5 min). But the size the package is slightly above limit (6.3 MB). I think CRAN will accept it, but we should still attempt to reduce a bit further.

I was thinking of re-submitting the package on the 30th.

If you get time, do you also mind having a look at ggbetweenstats (or purrr_examples) vignette? They are the largest and most time-consuming vignettes right now.

[IndrajeetPatil]

ggstatsplot 0.0.6 is now on CRAN:
https://cran.r-project.org/web/packages/ggstatsplot/index.html

[ibecav]

Congratulations!

…

On Sun, Sep 30, 2018 at 7:09 PM Indrajeet Patil ***@***.***> wrote: Closed #44 <#44>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#44 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AZU62fbDhatzNjWT24mq8t2zSNDdYrKeks5ugU87gaJpZM4Wpkty> .