GithubHelp home page GithubHelp logo

Comments (8)

kaushikcfd avatar kaushikcfd commented on August 29, 2024 1

Tried just adding a continue instead of the raise in there, but loopy doesn't appreciate it either and fails here (next to a FIXME)

Trying out a solution here: inducer/loopy#454

from meshmode.

alexfikl avatar alexfikl commented on August 29, 2024

Actually this doesn't seem to have worked with the transformations from arraycontext.PyOpenCLArrayContext either. Should it work?

from meshmode.

inducer avatar inducer commented on August 29, 2024

That conditional is a bit rigid in retrospect. It's fine to relax that (and not tag any inames as a result).

from meshmode.

alexfikl avatar alexfikl commented on August 29, 2024

Tried just adding a continue instead of the raise in there, but loopy doesn't appreciate it either and fails here (next to a FIXME)

https://github.com/inducer/loopy/blob/e232bb1361479f2e6fd3bd7efd7f4ecce270947f/loopy/target/c/codegen/expression.py#L152-L155

(the offset is lp.auto)

from meshmode.

inducer avatar inducer commented on August 29, 2024

(As a workaround, you could just **0.5 for now.)

Nvm, I guess you already discovered that. :) Thanks for the report. This should be a straightforward fix on the Loopy end.

from meshmode.

inducer avatar inducer commented on August 29, 2024

IIUC, @kaushikcfd just applied the meshmode half of this fix in #243. Now it's just the loopy FIXME that remains.

Somewhat related: inducer/loopy#453

from meshmode.

alexfikl avatar alexfikl commented on August 29, 2024

Just tried it out and can confirm that this seems to work with inducer/loopy#453 and inducer/loopy#454

from meshmode import _acf
actx = _acf()
x = actx.zeros(4, np.float64) + 4
actx.np.sqrt(actx.np.sum(x))

from meshmode.

inducer avatar inducer commented on August 29, 2024

I will revert the "solution" to this, see inducer/loopy#453 (comment). We will have to come up with a different way to solve this.

from meshmode.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.