GithubHelp home page GithubHelp logo

Comments (4)

Zalastax avatar Zalastax commented on July 1, 2024 2

@trueadm The component in itself looks correct and the site looks beautiful. I'm looking forward to using inferno in the future.
The problem is in the manually calculated values on

{ label: 'Vanilla JS', value: 0.1, score: 1.0 },
{ label: 'Inferno 1.0', value: 0.14, bg: '#e41f1c', score: 1.04 },
{ label: 'Angular 2', value: 0.52, score: 1.42 },
{ label: 'Ember 2', value: 0.74, score: 1.64 },
{ label: 'React 15.4', value: 0.49, score: 1.39 },
{ label: 'Vue 2', value: 0.47, score: 1.37 }
. Vanilla JS gets the value 0.1 so it's very short for its score. The pattern for all of the frameworks is that value = 0.1 + (score - 1), except for infernojs with a value of 0.14 where I expected 0.104 (so it's actually bigger than expected). A better value function is to not cut the lower part of the score: value = score / 1.64. I can make a PR with either the scores recalculated or the component updated to automatically scale based on Math.max(...data.map(v => v.score)) if you want.

from inferno-website.

trueadm avatar trueadm commented on July 1, 2024

@Zalastax The chart is scaled depending on the viewport by % of value in terms of the range, rather than the size indicating a 1:1 of score. This is commonly done on all benchmarks/review sites that use ranges. How would you change it to show the values differently?

I'm completely happy to fix it if something in the component itself is broken too – it's been a hectic last few weeks getting the site ready :)

from inferno-website.

trueadm avatar trueadm commented on July 1, 2024

Ah so there was a bug! A PR would be awesome thanks :)

from inferno-website.

Havunen avatar Havunen commented on July 1, 2024

Also it would be nice to get new benchmark with latest versions of all libs

from inferno-website.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.