socket files; plugin dir about docker-infoblox

[yuewko]

Yes. It is done using the shell script wrapper (at least for rm socket file) for now, which I thought is more appropriate.
I'm open to doing inside the driver if you so incline.

[johnbelamaric]

I see. I don't know, it seems like most containers can be run directly, so that is why I thought perhaps it should change. I wouldn't want our run/deployment to be different than the norm.

On Feb 12, 2016, at 2:15 PM, yuewko <[email protected]mailto:[email protected]> wrote:

Yes. It is done using the shell script wrapper (at least for rm socket file) for now, which I thought is more appropriate.
I'm open to doing inside the driver if you so incline.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/5#issuecomment-183454920.

[yuewko]

In which case, I propose adding the following options:

-plugin-dir (default to /run/docker/plugins)
-plugin-name (default to Infoblox)

The socket created will be, by default /run/docker/plugins/Infoblox.sock
The code will make sure /run/docker/plugins exists and will delete /run/docker/plugins/infoblox.sock if exists.

[johnbelamaric]

Ok. Should that be "plugin_name" or "driver_name"? I think either works but since it's "--ipam-driver" on the network create side, using "driver_name" may be clearer.

[yuewko]

Good point. So,
--plugin-dir
--driver-name

Obviously, that replace -socket.

[yuewko]

Fixed by pull request: #9