GithubHelp home page GithubHelp logo

Comments (5)

gmazzap avatar gmazzap commented on August 26, 2024 1

@tfrommen we already have a custom visitor which is used to generate some class/function stubs from fixtures instead of the WP code.

The purpose is to use advanced Psalm types for argument and return types.

Extending that visitor to also parse functions to extract constants looks like a good idea to me.

from wp-stubs.

gmazzap avatar gmazzap commented on August 26, 2024

One of the reasons this repo exists is because alternative packages don't have constants.

So yes, we should have constants.

Here the config that includes constants: https://github.com/inpsyde/wp-stubs/blob/main/generate.php#L41

So not sure why constants are not there...

from wp-stubs.

tfrommen avatar tfrommen commented on August 26, 2024

I ran into this as well just last week.
In the generated files, there are constants, but very few only.

I don't know if, by default, the parser only looks at define and const in the global scope, but maybe not in functions? A lot of the default contants are defined through the wp_initial_constants function.

from wp-stubs.

tfrommen avatar tfrommen commented on August 26, 2024

Oh, it does indeed seem to be the issue.

https://github.com/php-stubs/generator/blob/bf758105124218225d59e698913ac852ee7d79c7/src/NodeVisitor.php#L136-L138

Since it is possible to supply a custom visitor, I guess we may want to create one that parses function bodies, maybe of select function names only...?

from wp-stubs.

tfrommen avatar tfrommen commented on August 26, 2024

This has been implemented in #7. Closing.

from wp-stubs.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.