improve logging system about spoon

[pschichtel]

I don't know how exactly they're doing it, but the logging in the Netty Project is pretty well done. I think they're using SLF4J with Logback as the Backend. By default they don't log a thing.

[monperrus]

There is already such a system, see spoon.processing.Severity and methods report/print in StandardEnvironment. They use log4j eventually. So there is also an interplay with the default log4j configuration (already discussed in another thread).

There is definitely room for improvement, PR welcome.

[swolf91]

What about replacing log4j with log4j2? I read about it last week. It's much faster. For example because strings will just be formatted if it's needed.
So logger.info("I'm a message with a const: " + 3.14f) will be replaced with logger.info("I'm a message with a const: {}", 3.14f);
So the strings won't be concatenated unless the log level has to be processed.

[monperrus]

I suggest to close this generic and old pull request.

[swolf91]

@monperrus This isn't a pull request!?
Actually it should be a discussion. But nobody feels to be addressed by this issue.

I actually tried out to replace log4j with log4j2 see the work here
But I didn't find a good configuration yet.

[monperrus]

The idea is not to keep unactive open issues, it hampers issue management.

I propose to close this one, and we'll discuss your PR when you feel it's ready for discussion.

[swolf91]

lol? I don't get it. Why don't you want to discuss something without a PR? There are more possibilities than replacing log4j with log4j2. Also that doesn't close this issue because a better logging system isn't simply done with another logging engine. So the PR wouldn't be enough.

And that issue is just unactive because nobody writes something about the actual topic. I don't know why you (your whole team; not you in person) ignore this.

[monperrus]

No activity for 3 months. Closing the issue.