Comments (7)
Hey buddy! Would you like some help on this? (I'm still an avid user :D)
from babel-plugin-react-html-attrs.
Made an issue to make sure I wouldn't forget.
Forgot.
I'll cut a release later today 👍
from babel-plugin-react-html-attrs.
=*
from babel-plugin-react-html-attrs.
@ericclemmons One thing before I do: I was considering backing out the change which added loads more attributes first because I think the plugin should attempt to restrict those fixes to creation of the specific HTML elements they apply to, otherwise it increases the scope for an incredibly confusing prop-naming bug if you happen to use one of them in a custom component.
Sound good?
from babel-plugin-react-html-attrs.
@insin Sorry, I don't fully understand. Can you give an example or describe what your preference is?
An alternative would be to keep the translations, but allow an option for the plugin to accept key/value pairs for the user to opt into.
from babel-plugin-react-html-attrs.
With the big translation list I reverted, if you wrote a component whose usage was something like <TimeSince datetime={this.state.someDate}/>
, you'd be scratching your head for a while before figuring out this plugin was silently changing it to dateTime
.
I could make it configurable, but class
and for
are the only ones which regularly bother me.
v2.1.0 is published now, but after releasing it and fixing the t o t a l l y incorrect test I added, it seems plugin order also matters.
from babel-plugin-react-html-attrs.
Thanks, this totally makes sense!
from babel-plugin-react-html-attrs.
Related Issues (14)
- Consider adding colSpan, rowSpan and possibly others HOT 2
- How to edit .babelrc HOT 1
- Restrict attribute renaming by JSX element name HOT 1
- The plugin "react-html-attrs" didn't export a Plugin instance while parsing file HOT 1
- Remove the attribute value for boolean attributes
- Option to white-list components HOT 1
- Cannot read property 'type' of undefined
- Consider converting the "style" attribute from a string to a CSSProperties object? HOT 2
- Babel 6 HOT 2
- Inlining elements
- How do you solve ESLint errors? HOT 4
- how about style arrtibute HOT 1
- how to handle typescript issue HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from babel-plugin-react-html-attrs.