GithubHelp home page GithubHelp logo

Comments (7)

ericclemmons avatar ericclemmons commented on August 15, 2024

Hey buddy! Would you like some help on this? (I'm still an avid user :D)

from babel-plugin-react-html-attrs.

insin avatar insin commented on August 15, 2024

Made an issue to make sure I wouldn't forget.

Forgot.

I'll cut a release later today 👍

from babel-plugin-react-html-attrs.

ericclemmons avatar ericclemmons commented on August 15, 2024

=*

from babel-plugin-react-html-attrs.

insin avatar insin commented on August 15, 2024

@ericclemmons One thing before I do: I was considering backing out the change which added loads more attributes first because I think the plugin should attempt to restrict those fixes to creation of the specific HTML elements they apply to, otherwise it increases the scope for an incredibly confusing prop-naming bug if you happen to use one of them in a custom component.

Sound good?

from babel-plugin-react-html-attrs.

ericclemmons avatar ericclemmons commented on August 15, 2024

@insin Sorry, I don't fully understand. Can you give an example or describe what your preference is?

An alternative would be to keep the translations, but allow an option for the plugin to accept key/value pairs for the user to opt into.

from babel-plugin-react-html-attrs.

insin avatar insin commented on August 15, 2024

With the big translation list I reverted, if you wrote a component whose usage was something like <TimeSince datetime={this.state.someDate}/>, you'd be scratching your head for a while before figuring out this plugin was silently changing it to dateTime.

I could make it configurable, but class and for are the only ones which regularly bother me.

v2.1.0 is published now, but after releasing it and fixing the t o t a l l y incorrect test I added, it seems plugin order also matters.

from babel-plugin-react-html-attrs.

ericclemmons avatar ericclemmons commented on August 15, 2024

Thanks, this totally makes sense!

from babel-plugin-react-html-attrs.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.