Comments (10)
Not sure why mentioning this in a comment auto-closed on merge
Certain keywords, like "closes" and "fixes" can be used to auto-close issues, however github isn't context sensitive. https://help.github.com/en/github/managing-your-work-on-github/closing-issues-using-keywords
from libcst.
This is on my list of TODOs underneath some deprecation tasks and continued work on matchers
API. I don't have any real timeline for supporting this but I can certainly bump priority since there is demand for it.
Support for 3.8 comes in two flavors, however: First is the ability to execute LibCST on 3.8 code. This should be available, but you're running into a snag with LibCST's automatic detection of versions. If a python version isn't supplied to the parser, it assumes the version that you're running and since we can't parse 3.8 yet, it fails. Fixing that is possible if you want to hardcode the parser version (which we do in some parser tests). The second flavor is arguably the only useful version, which is the ability to parse 3.8 code, regardless of the currently running python. That's what I assume this feature request is for, and what I can't give an official timeline on yet.
Can you provide your own timeline and such so I can tell how urgently this needs to get addressed?
from libcst.
@dseevr, yes, we've started the work of Python 3.8 supports and some preliminary support was published in LibCST 0.2.3
https://github.com/Instagram/LibCST/blob/master/CHANGELOG.md
from libcst.
Once #213 and #209 are in, we will fully support Python 3.8, both in executing LibCST and in parsing/generating code. I plan to make a release sometime this week.
from libcst.
We don't have plans for complete 3.8 support for the rest of the year. However, the preliminary support pushed on the 11th of last month should be enough to unblock Pyre (and it has unblocked sister teams). Pyre needs to upgrade their dependency to 0.2.4.
from libcst.
Oops, forgot to close this. This is live now.
from libcst.
That's fine. Long as it's planned :) I have disabled it in ptr for >= 3.8 for now. My PR is linked above to do this. I'll keep an eye and when this is closed I'll undo the disable :)
from libcst.
Not sure why mentioning this in a comment auto-closed on merge, but this is not finished.
from libcst.
Is this issue being looked at/considered for development? We've had to stop using pyre entirely because it's blocked on this issue.
from libcst.
Hey @dseevr, that sucks. Unfortunately, Thanksgiving is approaching, and a lot of people are on vacation, so we might not be able to get back to you until next week.
from libcst.
Related Issues (20)
- cst.IfExp test/body print order differs from lexical order in code
- [Feature Request] evaluated_value() method on [static] containers HOT 2
- MatcherDecoratableTransformer >3x slower than CSTTransformer, despite using no decorators
- Set matchers and the typing of get_qualified_name_for
- Documentation: never use `updated_node` to access node metadata HOT 1
- ~~[typing] leave_With (and others) do not allow returning FlattenSentinel[cst.BaseSmallStatement]~~
- Matchers trigger when original node matches even if current version doesn't
- Source code with CR and CRLF line endings causes PanicException
- Native parser ignores value of `default_newline` from PartialParserConfig
- CSTNode.deep_replace type annotations incomplete
- RecursionError in __getattr__ when running with multiprocessing
- Invalid code generated for `Comparison` with missing parens
- Crash on parenthesized async context manager without trailing comma HOT 3
- Parsing does not raise error for code assigning to a function call HOT 5
- Native parser crashes on `rf"\\"`
- Implement support for PEP-695
- RemoveImportsVisitor crashes when parsing Literal["r+"] HOT 1
- Real-world code snippets which `libcst` fails to parse HOT 8
- A way to silence "Failed to determine module name"? HOT 2
- Support LSP for `TypeInferenceProvider` HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libcst.