Resources requests/limits fails to validate when providing the number of CPUs as integers about kubeval

[garethr]

So, according to the specification this is actually doing the right thing. However Kubernetes doesn't use quite the same rules internally so kubeval is finding a bunch of similar issues. I'll open upstream bugs when I get a moment and also talk to SIG API Machinery about the actual internal implementation so I can have kubeval do the right thing.

From the upstream OpenAPI description at https://raw.githubusercontent.com/kubernetes/kubernetes/master/api/openapi-spec/swagger.json

io.k8s.api.core.v1.ResourceRequirements: {
  description: "ResourceRequirements describes the compute resource requirements.",
  properties: {
    limits: {
      description: "Limits describes the maximum amount of compute resources allowed. More info: 
https://kubernetes.io/docs/concepts/configuration/manage-compute-resources-container/",
      type: "object",
      additionalProperties: {
        $ref: "#/definitions/io.k8s.apimachinery.pkg.api.resource.Quantity"
      }
    },
    requests: {
      description: "Requests describes the minimum amount of compute resources required. If Requests is omitted for a container, it defaults to Limits if that is explicitly specified, otherwise to an implementation-defined value. More info: https://kubernetes.io/docs/concepts/configuration/manage-compute-resources-container/",
      type: "object",
      additionalProperties: {
        $ref: "#/definitions/io.k8s.apimachinery.pkg.api.resource.Quantity"
      }
    }
  }
},

Note that cpu and memory are not explicitly defined, but resources can take additional properties as long as they are of type quantity. Quantity is defined as:

io.k8s.apimachinery.pkg.api.resource.Quantity: {
  type: "string"
},

So:

• the error appears at the limit and request key because they are additional properties. I'll see if the actual key is available from the json schema Go library, or file a bug for that
• the spec actually says this should be a string. If you try with "200m" I think it will work for instance.
• Kubernetes accepts null to mean blank string, hence the [string,null] part of the error which kubeval adds in

[garethr]

Posted a clarifying question to SIG API Machinery at https://groups.google.com/forum/#!topic/kubernetes-sig-api-machinery/dLCXrZRwWpU

[garethr]

This should now work as expected. Tests in 06e025e

The fix is in the upstream schemas in 06e025e so should work without needing you to update kubeval.

[garethr]

This is not really a bug. It's a convenience feature specific to Quantity

I'll update the upstream specs to allow Quantity to be a number.

[garethr]

I've also opened an upstream bug to track a fix in this spec kubernetes/kubernetes#50957

[thedrow]

Wonderful! Thank you very much.