Comments (11)
This shouldn't be an FSP issue:
The reason why ACPI mode is always enabled is not due to FSP firmware bug. It is a combination of coreboot ACPI override code and serial console delay.
The FSP is correctly populating PcdEnableHsuart0 and PcdEnableHsuart1.
The serial console delays its output on first boot that it only displays debug logs during DXE. By that time coreboot has already overridden HSUART1 and HSUART2 in ACPI mode. That is why the logs always report ACPI mode is enabled.
--> To workaround it for coreboot, kindly apply the patch as illustrated as follow:
This patch will target only to coreboot and this can be the permanent fix.
It has been tested with BCT to check whether or not if the changes will take effect.
The patch works every time when changing PcdEnableHsuart0 and PcdEnableHsuart1, it is reflected in the logs. In Yocto, it's verified that HSUART1 is active when enabled.
from fsp.
Adding @swang57 @nate-desimone-intel
from fsp.
It's been a month without a reply. Any update on this issue ?
from fsp.
Hi @PatrickRudolph, we just posted the latest and greatest version, can you give this one a try and see if it helps?
from fsp.
@nate-desimone Where is it? It's not on the master branch.
from fsp.
Hi @siro20, yes it is:
https://github.com/IntelFsp/FSP/tree/master/BraswellFspBinPkg/FspBin
Version 1.1.8.0 was posted last Friday, we matched the 1.1.8.0 commit date with the date that the binary was originally compiled.
from fsp.
Bug is still valid as reported in https://review.coreboot.org/c/coreboot/+/28464
from fsp.
It's been a few month. Any update on this issue?
from fsp.
Hi All,
It looks like this issue was found during development of the firmware for the "Facebook FBG-1701" system. Would it be possible for someone from Facebook whom has a support contract with Intel to file an IPS ticket?
I think the added justification of a customer with a support contract asking for this fix will increase visibility on this issue. Otherwise Intel management is unlikely to allocate engineering time for new firmware development on a 5 year old SoC, especially since you have a workaround.
from fsp.
It seems we'll get a Technical Advisory, but a new FSP will not be released to fix this. Perhaps the fix will come in a future FSP release, but for now https://review.coreboot.org/c/coreboot/+/28464 will need to be used as a workaround.
from fsp.
Thanks @swong23! I added a comment at https://review.coreboot.org/c/coreboot/+/28464/ to let others know that you have found the root cause.
from fsp.
Related Issues (20)
- UP3 Tigerlake Based Circuit Board: CRC For DIMM Fails. So Fast Boot Never Occurs! HOT 14
- Missing important FSP Hob structs header files for EagleStreamFspBinPkg HOT 13
- Meteor Lake is missing header files
- Issues with EagleStream/SPR-SP FSP HOT 4
- Meteor Lake Client FSP
- ADL-N Headers have wrong address in headers
- wrong file headers in a public code
- Header file contains "confidential" note
- TGL_IOT FSP missing `FirmwareVersionInfoHob.h` header HOT 1
- error: ‘FspPcdListLibNull’ defined but not used HOT 1
- ElkhartLake MR5 VBT BSF file is not correct HOT 2
- Raptor Lake-S (LGA 1700) FSP support HOT 1
- Tiger Lake IOT FSP files contain "Intel Confidential" in license headers HOT 1
- Alderlake N is missing MemInfoHob.h HOT 1
- Alder Lake N is missing FirmwareVersionInfoHob.h HOT 4
- Sapphire Rapids FSP HOT 3
- Raptor Lake Refresh-S (LGA 1700) FSP support HOT 1
- Building FSP for Sapphire Rapids HOT 2
- Missing MrcCommonConfig.dsc file in EagleStream HOT 9
- BCT can't open Eagle Stream's bsf HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fsp.