Update MKL-DNN submodule about ideep

[gujinghui]

on track. will update here if any.

[mingxiaoh]

mkl-dnn works as an submodule in this repo, however its latest version depends on global cmake variables, such as CMAKE_SOURCE_DIR, CMAKE_BINARY_DIR, which will lead to building error for ideep, we are contacting with mkl-dnn team for the solution now.

[mingxiaoh]

grad to tell you that I was told by mkl-dnn team that they will fix the global cmake variables dependency problem on v0.17, so hopefully we can update mkl-dnn version in one or two weeks. sorry for keeping you waiting.

[mingxiaoh]

@kleisauke that PR has been merged to master on https://github.com/01org/mkl-dnn.git, however, during our release test, we found that there is another issue we need to fix. Anyway, we plan to update submodule of MKL-DNN this Friday. Sorry for the delay.

[gujinghui]

The above PR has been merged. 🎉

I noticed that the submodule URL of MKL-DNN is still on https://github.com/01org/mkl-dnn.git instead than https://github.com/intel/mkl-dnn.git (see here). Perhaps the URL also needs to be updated?

Sure. Will fix the URL.

[mingxiaoh]

@kleisauke we have updated ideep(and mkldnn version) in master branch, which includes the fix for GCC-8 compilation problem. we did not update mkldnn to latest version since there is some bugs we need to handle. Thanks.

[mingxiaoh]

thanks for the notification, we will try and see.

[happydig]

any progress on this?

[mingxiaoh]

mkl-dnn team won't include the fix on v0.17, but they will push the fix to github master in 1 week, so we will update mkl-dnn version once we got the fix and finish the corresponding test. sorry for keeping you waiting.

[kleisauke]

I just came across PR pytorch/pytorch#14308, thanks!

[kleisauke]

The above PR has been merged. 🎉

I noticed that the submodule URL of MKL-DNN is still on https://github.com/01org/mkl-dnn.git instead than https://github.com/intel/mkl-dnn.git (see here). Perhaps the URL also needs to be updated?