Rework VP8 encoder with new VP8 shaders on SKL/APL/KBL about intel-vaapi-driver

[seanvk]

@xhaihao You forgot to add to the commit header Fixes #n so these bugs are still hanging about.

[xhaihao]

@seanvk I'd like to add "Fixes " instead of "Fixes #n" in the commit, github will change the URL to #n automatically in the github environment but keep the commit message unchanged.

E.g. in commit 71f77c6
This fixes #46

The issue of 46 was also closed automatically

I think a URL is better than a number for a reader and it is easy to reach the issue in a browser.

It was my fault not to provide a whole URL in the commits for vp8-rework

[seanvk]

On Wednesday 22 Feb 2017 at 16:54:17 (-0800), Xiang, Haihao writes :

***@***.*** I'd like to add "Fixes " instead of "Fixes #n" in the commit, github will change the URL to #n automatically in the github environment but keep the commit message unchanged. E.g. in commit [2]71f77c6 This fixes [3]#46 The issue of 46 was also closed automatically I think a URL is better than a number for a reader and it is easy to reach the issue in a browser. It was my fault not to provide a whole URL in the commits for vp8-rework

Haihao, There is always a record. Please do both if you want to include the URL. Fixes #n is standard practice with Github and if you want to include the URL you can. This is no different than Google Chrome. We all know it is a Github project and the # can easily be found from the Github project. Thanks, Sean

…

— You are receiving this because you were mentioned. Reply to this email directly, [4]view it on GitHub, or [5]mute the thread. Reverse link: [6]unknown References Visible links 1. https://github.com/seanvk 2. 71f77c6 3. #46 4. #40 (comment) 5. https://github.com/notifications/unsubscribe-auth/AA0coURm6NYApuMWVpMo6RXrldF2adPgks5rfNi5gaJpZM4L8_9y 6. #40 (comment) [proxychains] DLL init: proxychains-ng 4.11 [proxychains] DLL init: proxychains-ng 4.11

[seanvk]

And @xhaihao if you use Github, the link will always be in the commit view from github:

For example:
03a86fc

So please continue to include Fixes #n You can add a URL if you want but that is needless duplication of a Github feature.

[xhaihao]

Yes, it is easy in github. but for a reader who is not using github, what does #n mean?

[seanvk]

On Wednesday 22 Feb 2017 at 17:35:26 (-0800), Xiang, Haihao writes :

Yes, it is easy in github. but for a reader who is not using github, what does #n mean?

The reader has to get the code from github. Github is where the issue number is tracked. They can look up the bug by the number in the commit. It's absolutely no different than Chrome or even Bugzilla numbers. It also allows us to have a standard flow for issue resolution. Thanks, Sean

…

— You are receiving this because you were mentioned. Reply to this email directly, [1]view it on GitHub, or [2]mute the thread. Reverse link: [3]unknown References Visible links 1. #40 (comment) 2. https://github.com/notifications/unsubscribe-auth/AA0cob7kvo5cmqOKNbPsyRlm6gvlN4PLks5rfOJegaJpZM4L8_9y 3. #40 (comment) [proxychains] DLL init: proxychains-ng 4.11 [proxychains] DLL init: proxychains-ng 4.11

[xhaihao]

@seanvk I agree we should have a standard flow for issue resolution, actually github supports "Fixes ".

My concern is a number in the commit log is meaningless. We moved from FDO to github, maybe we will move from github to another place in the future. A reader doesn't know what is the number when he go through the whole git log.

[seanvk]

This is no different than having a bugzilla number or a chrome bug number. They can look up where they got the source from. If you insist its trivial to just say Fixes 01org/intel-vaapi-driver#n or Fixes #n. Either will work. Thanks, Sean

…

On Feb 22, 2017, at 6:09 PM, Xiang, Haihao ***@***.***> wrote: @seanvk <https://github.com/seanvk> I agree we should have a standard flow for issue resolution, actually github supports "Fixes ". My concern is a number in the commit log is meaningless. We moved from FDO to github, maybe we will move from github to another place in the future. A reader doesn't know what is the number when he go through the whole git log. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#40 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA0cob_X36g-bkmYt43txv-mW1AiyXLDks5rfOo-gaJpZM4L8_9y>.