GithubHelp home page GithubHelp logo

Comments (4)

uzaxirr avatar uzaxirr commented on June 14, 2024

Could you enlighten me on the purpose of files currently present in tests/greedybear/cronjobs
I guess i just have to add a __init__.py file in the currently present tests directory to convert it into a module and add test for CRUD methods on existing models and test the API endpoints.

or do i have to make utils for APIView

Please correct me if i'm wrong in any of the above

from greedybear.

mlodic avatar mlodic commented on June 14, 2024

well, actually there are not tests enabled in the CI (see pull_request_automation.yml).

As you mentioned, in that folder there are some tests but:

  • they only work if manually launched because they require to have an ElasticSearch instance with the right data active and connected. This is why I asked to mock ElasticSearch connections (fake them and have them return fake data so the code would correctly execute until its end) to have the tests working even in the Github CI.
  • those tests are only for the cronjobs part (interaction with ElasticSearch). As you mentioned, there are no tests for the API endpoints and we should add them (something very similar to the tests for the APIs in IntelOwl)

from greedybear.

uzaxirr avatar uzaxirr commented on June 14, 2024

Cool seems fine, can you assign it to me as my current PR is under-review from a long time so would work on this one parallelly.

from greedybear.

mlodic avatar mlodic commented on June 14, 2024

dolved in #38

from greedybear.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.