Running migrations before running tests about pliny

[DyegoCosta]

@cyberdelia did you mean to add it to the template spec_helper? I think it's a good idea as well, I can add that check

I believe we have two options here, use the Sequel default error message

Sequel::Migrator.check_current(DB, "#{Config.root}/db/migrate")

$ rake                                                                      [ruby-2.2.1]
rake aborted!
Sequel::Migrator::NotCurrentError: migrator is not current
/Users/dyego/.rvm/gems/ruby-2.2.1/gems/sequel-4.24.0/lib/sequel/extensions/migration.rb:368:in `check_current'
/Users/dyego/code/magenta/spec/spec_helper.rb:11:in `<top (required)>'
/Users/dyego/.rvm/gems/ruby-2.2.1/gems/rspec-core-3.3.2/lib/rspec/core/configuration.rb:1280:in `require'
...
Tasks: TOP => default => spec
(See full trace by running task with --trace)

Or check if it's current and fail with our own error message

unless Sequel::Migrator.if_current(DB, "#{Config.root}/db/migrate")
  fail "Our own error message"
end

Do you think we need a custom message or Sequel's default is fine?

[cyberdelia]

I would rather have the migration applied rather than just a check, but that could be a could be a good first step.

[gudmundur]

I like the idea, yet I'm reluctant to running the migrations automatically. If we do, then what should we do with the -development database? Often you'll also want your tests to pass, even though you haven't migrated the database. The example I'm thinking here is where you have deployed things, but migrations haven't run yet.

I think the nice thing to do here is to give a warning. What do you think?

[cyberdelia]

The main goal would be to avoid running tests against an outdated schema. What we currently do is:

begin
  require "sequel/extensions/migration"
  Sequel::Migrator.check_current(Sequel::Model.db, 'db/migrate')
rescue Sequel::Migrator::Error
  abort("Test database is not up-to-date, please run: bundle exec rake db:setup")
end