WooCommerce: Imgix returning 422 for single product images about ilab-media-tools

[JulienMelissas]

Just wanted to weigh in again... I went back to 2.1.9 instead of my fix posted above and product images are working again. If I can take a look at this tomorrow maybe I'll be able to submit a PR. It's just hard to navigate since I didn't write the plugin itself.

Thanks for your continued work on this plugin, we're loving Imgix and serving well over 2m images a month. The last few updates def. cleared up a few bugs. 🍻

[tapetersen]

I can confirm that there is some regression regarding thumbnail sizes that has 1 dimension set to 0. This should normally be handled by ignoring that dimension and just calculate the ratio based on the other one. I'll see if I can bisect down the issue and fix it.

[tapetersen]

Ok there seems to be 2 issues, the first one that breaks proportional resizing with 1 parameter set to 0 was introduced in ecb5c31. Havn't checked details but it causes them to be completely square instead, It's a bit complicated to see what it was trying to solve but I'll try to see if I can understand. After that another change Made the images disappear completely (generated 0, height and width). Will bisect for that as well.

[tapetersen]

Ok looks like the main error was replacing the logic for $sizeInfo['width'] ?: 10000 with (isset($sizeInfo['width'])) ? $sizeInfo['width'] : 10000 which fails for a width set explicitly to 0 or "0" which should behave the same (according to wordpress's implicit rules) and has before. There has been some more modifications since then so I will try to write an updated PR (there is another bug like it for the crop value set explicilty to false but that is corrected in the later versions already).

[jawngee]

Great catch thanks!

I actually came across this bug testing out WooCommerce because people had been reporting issues. I never use the Woo so my testing was probably pretty limited.

[michaeljberry]

Thanks for working on a fix to this. I see that you committed the fix, but I don't know the timeframe or process for plugins to be updated on WordPress' servers. Do you know when this fix will be available to update?