Release fails with `Error: fatal: ' 9007199254740991': not an integer` about auto

[hipstersmoothie]

We're getting the fix out!

[Zweer]

PR opened : #2426

[tferullo]

If anyone is running into this on Github Actions ubuntu runner, I have the worst temporary workaround ever:

- name: Install specific git version
  run: |
    sudo apt-get update
    sudo add-apt-repository ppa:git-core/ppa 
    sudo apt install git=1:2.34.1-1ubuntu1.10 git-man=1:2.34.1-1ubuntu1.10 -y --allow-downgrades

don't judge me, it works.

[jazmon]

@ecstaticrainbow here

index a28a5eb2565d237bd0eff65e6222511287424b5a..464a642e71538ed8e79291b41bae821512eaa950 100644
--- a/dist/git.js
+++ b/dist/git.js
@@ -240,9 +240,11 @@ class Git {
             const startSha = (await this.shaExists(start))
                 ? await exec_promise_1.default("git", ["rev-parse", start])
                 : "";
+            const maxNumber = 2147483647;
             const log = await gitlog_1.gitlogPromise({
                 repo: process.cwd(),
-                number: Number.MAX_SAFE_INTEGER,
+                number: maxNumber,
                 fields: ["hash", "authorName", "authorEmail", "rawBody"],
                 // If start === firstCommit then we want to include that commit in the changelog
                 // Otherwise it was that last release and should not be included in the release.

[patjacobs-magic]

11.0.5 fixes the issue for me. Thank you for the quick turnaround!

[mackermans]

Git v2.43.2 seems to be the issue, v2.42.0 still works:

> git log -n 9007199254740991
fatal: '9007199254740991': not an integer

[tferullo]

This will fail once that version of git is not published in the git-core ppa anymore

Yup, very excited for that 😄

[hipstersmoothie]

If any contributors want to help maintain auto I'm open to the idea! auto def hasn't been on my mind since moving to a more product focused role but I still use the project outside work a lot. I've now moved back to a platform team so I'll be more active.

(If anyone want to just that platform team we're hiring descript.com)

[aldrichdev]

Oddly, this issue resolved itself after removing my package-lock.json file (there was a warning about it in the build, since we also have yarn.lock and use yarn mostly), and adding "license": "UNLICENSED", to my package.json, which fixed another warning. Did not think these two changes would fix the issue altogether, but that seems to be what has occurred. Closing.

[aldrichdev]

Actually, it seems the issue resolved itself only temporarily. Even with the changes I mentioned above still applied, I am getting the same error again with a new PR. So I still need help.

[patjacobs-magic]

I also started getting this exact error today.

"auto" version: v10.42.2
"git"  version: v2.43.2
"node" version: v20.11.1

[jazmon]

Number.MAX_SAFE_INTEGER seems to be too big now as of git v2.43.2, we ended up patching it and using 2147483647 as the new safe maximum instead. This repo seems unmaintained though so I can highly recommend patching it manually for now

[ecstaticrainbow]

@jazmon Do you have an example of the patch? Unsure what and where you'd put a fix. Thanks

[laughedelic]

@jazmon could you still submit a PR? I can do it if you don't have time, just let me know.

Maybe we can get @hipstersmoothie to merge the fix for this blocking bug?

[jazmon]

I would but I have an open PR #2414 that fixes another bug here and it's been open for months without anyone looking at it, doesn't seem very productive to create any more PRs to fix things. Might need to fork this library instead

[sqaisar]

@tferullo It works with these specific git versions. This should be fixed in this repo.

[Ermag]

Here is a shell command that applies the fix from @jazmon

sed -i 's/Number.MAX_SAFE_INTEGER/2147483647/' ./node_modules/@auto-it/core/dist/git.js

[jazmon]

Thanks @Zweer for the PR 👍

If anyone is running into this on Github Actions ubuntu runner, I have the worst temporary workaround ever:

- name: Install specific git version
  run: |
    sudo apt-get update
    sudo add-apt-repository ppa:git-core/ppa 
    sudo apt install git=1:2.34.1-1ubuntu1.10 git-man=1:2.34.1-1ubuntu1.10 -y --allow-downgrades

don't judge me, it works.

This will fail once that version of git is not published in the git-core ppa anymore

[fernandoiury]

This will fail once that version of git is not published in the git-core ppa anymore

Yup, very excited for that 😄

I think you command is actually installing the ubuntu repo version not the ppa.

[wpniederer]

Also having the same issue for my repos using Auto, starting today.

[aldrichdev]

11.0.5 is working well so far. Thank you @jazmon, @Zweer and @hipstersmoothie! Closing this issue.