inuitcss / objects.flag Goto Github PK

Would you consider adding tiny and huge flags? Default values could be quarter/quadruple of $inuit-flag-gutter, respectively.

Using the direct child selector in .flag__img > img {} means it is not possible to wrap the img in, say an <a> link.

Remove the child selector to leave .flag__img img {}

Hello everyone, hello Harry,

I was asking why images aren't width 100% when responsive, or at least why they aren't centered.

And also, wouldn't it be nice to have an image with a defined max-width, in order to be able to put bigger images without them to be huge in the desktop version ?

Thank you for your amazing work,

Something like :

@include media-query('palm') {
  .flag__img > img {
    width: 100%
  }
}

.flag__img > img {
  max-width: 200px;
}

I also don't understand why the $inuit-flag-collapse-at is not by default the 'palm' size.

Have a great day

- Thibaut

.flag--top and .flag--bottom should target only child .flag__img/.flag__body classes (via child selector combinator).

Is there a plan/workflow how pull request for new inuit would work? I'd be happy to contribute :)

Having this link to your blog post somewhere on README.md would be helpful, but wasn't sure if you chose not to. http://csswizardry.com/2013/05/the-flag-object/

There is a bug with .flag__body in Webkit/Blink based browsers if its parent is table cell (actually display: table-cell, I didn't check actual tables). It seems to take more space than it should. Let me demonstrate it here. If you check it in Firefox you will see how it should behave.

The fix is to remove width: 100% from .flag__body (or explicitly set it to width: auto just to be sure) and set width: 1px to .flag__img. I have picked up the fix from an old(ish) article here. Here's what the author has to say about this:

By setting height/width:1px a normal cell will use the minimum amount of space to display its contents, leaving all unused space for the .Expand class cells with height/width:auto.

And here's a pen for the fix. This probably needs more testing, but it seems to not mess things up.