should logrus be vendored revisioned? about rye

[johannesinvision]

For what it's worth, my understanding is that rye won't pull the latest version of logrus—it will use what's in the importing repo's vendor folder (if there is one).

[bettse]

@talpert / @johannesinvision y'all ever see this issue?

[johannesinvision]

I had an issue with this when I had a recent version of logrus and were using rye. I'm pretty new to golang, but my intuition would be that libraries didn't vendor libraries much and left that to the final user. Of course that would lead to issues like I was experiencing, but it will reduce conflicting versions and bloat once it actually compiles.

[dselans]

It's too late to change now but rye having direct refs to external libs in the main pkg is not great. While there's a good chance that folks already have logrus in their project, this will indeed pull logrus in when they vendor all external deps. Better solution would be that middlewares were in their own pkg.

That might have to be v2 though.

Closing.