Comments (3)
This has to be added since v1.2.3.
from gree-hvac-client.
Hi Ilya, you're right. This isn't consistent to have 1/0 and 'on'/'off' while getting and setting properties if I understand the issue right. This seems to be a bug.
I think this could be easily fixed by making constants to be 'on'/'off'. This should work by default since PropertyTransformer
expects exactly those string values.
But in fact I would like to make it configurable, since some users would like to get/set the original vendor 1/0 and their original property names like SetTem: 25
instead of temperature: 25
or WdSpd:2
instead of fanSpeed:mediumLow
for some reasons.
I'm on a vacation right now but I will get to this in a week.
Thanks for feedback.
from gree-hvac-client.
Thanks.
from gree-hvac-client.
Related Issues (5)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gree-hvac-client.