ioanadamo / f-m1-evaluacion-intermedia-daniela932910 Goto Github PK

Really cool job @daniela932910 !!!

Here you have some tips to improve the exercise:

• Improve the meta title of the page
• We need an h1 tag
• Humanize text in alt attributes, a sentence without the underscore may do the trick.
• Class selectors are free, let's use them instead tag selectors
• Try to avoid using tags names on classes
• Fix the header to the viewport (you have a syntax error)
• You have a vertical scroll, something is causing it, let's find it and fix it.
• Nav links should be thinner.
• Avoid uppercase/capital on HTML texts, and br tag we can transform the text with CSS; this way we keep concepts separated, HTML for content, and CSS for styles
• Finish the main title styles: words should jump and the typography is bolder
• Indent and avoid extra white spaces to improve readability and avoid bugs
• Try to use imperative for your commit messages. Ex. - > Fix central text
• Organize your files in folders, you have a guide to help you with that here --> https://books.adalab.es/materiales-front-end-f/modulo-1.-hola-mundo/1_1_intro_a_la_web#notas-finales-sobre-como-organizar-nuestro-proyecto

Let me know if you have any doubts ;)

Go for it!!