GithubHelp home page GithubHelp logo

Comments (3)

romanarangodev avatar romanarangodev commented on April 28, 2024 3

Hi, I was having the same issue with ion infinite scroll, but after a lot of hours trying to find a solution. I found that using this.infiniteScroll.complete().then(resp=>{
this.infiniteScroll.disabled=true
}) works.

this is mi code, I was working with observables.

async onIonInfinite(event?:any){

this.usuarioService.getTareasByBusqueda(this.termino).subscribe({

  next:(tareas) => {
   

    this.loading=false

    if(tareas?.length===0){
     
      this.infiniteScroll.complete().then(()=>{
         this.infiniteScroll.disabled=true
      })

      return;
    }

    this.usuarioService.miListaDeTareasPorBusqueda.push(...tareas)
    this.usuarioService.miListaDeTareasPorBusquedaBS.next(this.usuarioService.miListaDeTareasPorBusqueda)

    this.infiniteScroll.complete().then(() => {
      this.infiniteScroll.disabled=false
    });

  },
  error:(error:any)=>{
    console.log(error);
    
  }

});

}

Hope this help others!

from ionic-framework.

brandyscarney avatar brandyscarney commented on April 28, 2024 2

Thank you for the issue! The complete() method on Infinite Scroll is async, so what is happening is disabled is being set before the complete method is finished. I have updated your provided example to reflect this and see it working now: https://stackblitz.com/edit/angular-wqu2xl-dpbszj?file=src%2Fapp%2Fexample.component.ts

I noticed that our documentation does not include an await, so I have made an internal ticket to get our documentation updated. Let me know if you have any questions!

from ionic-framework.

bkeepers avatar bkeepers commented on April 28, 2024

I just ran into this and took way too long to figure out. Like @romanarangodev, I found that you can't disable the ion-infinte-scroll element between the ion-infinite event being fired and the complete callback being called. If you do, it will not re-enable.

This is what I was doing in Vue, which worked great in Ionic 6:

  <ion-infinite-scroll
    :disabled="isLoading || isDonePaginating"
    @ion-infinite="load().then($event.target.complete)"
  ></ion-infinite-scroll>

I had to stop using disabled, and just remove the element entirely with v-if once the list was done paginating.

  <ion-infinite-scroll
-   :disabled="isLoading || isDonePaginating"
+   v-if="!isDonePaginating"
    @ion-infinite="load().then($event.target.complete)"
  >
     …
  </ion-infinite-scroll>

The side-effect of this thought is that there are times where it will kick off multiple @ion-infinte events in succession if the user continues to scroll once passing the threshold, so depending on your implementation, you may want to throttle those events.

It would be ideal if the Ionic 6 behavior was restored where the element could be disabled while loading.

from ionic-framework.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.