Comments (10)
@deleonio I have a dev build for you with a fix. Yoi can install it via npm i @stencil/[email protected]
. I recommend to update Jest to avoid these types of compatibility issues moving on.
from stencil.
@deleonio thanks for verifying. I will go ahead and close the issue. The fix will be released next week.
from stencil.
Hey @deleonio thanks for reporting this, I wasn't able to reproduce that error locally my testing. Would you possibly be able to put together a minimal reproduction? Without that we have a hard time debugging errors.
from stencil.
Thanks for the issue! This issue has been labeled as needs reproduction
. This label is added to issues that need a code reproduction.
Please reproduce this issue in an Stencil starter component library and provide a way for us to access it (GitHub repo, StackBlitz, etc). Without a reliable code reproduction, it is unlikely we will be able to resolve the issue, leading to it being closed.
If you have already provided a code snippet and are seeing this message, it is likely that the code snippet was not enough for our team to reproduce the issue.
For a guide on how to create a good reproduction, see our Contributing Guide.
from stencil.
Here I prepare a reproduction sample: https://github.com/deleonio/kolibri-library/tree/reproduction-5766
pnpm i
pnpm test
4.18.0 works
4.18.1 does not work
The following files contains node:path
:
> grep -rl "node:path"
./test/wdio/invisible-prehydration/invisible-prehydration.test.tsx
./test/wdio/prerender-test/cmp.test.tsx
./test/wdio/wdio.conf.ts
./test/wdio/util.ts
./scripts/esbuild/dev-server.ts
./scripts/updateSelectorEngine.ts
Maybe scripts/esbuild/utils.ts
--- https://github.com/ionic-team/stencil/compare/v4.18.0...v4.18.1#diff-ca5c0dbb4baece2d3fbe79900e692152217277778ef3679274a74c5c0ee4057dR5
Hint: It looks like a similar misstake ... #5358
from stencil.
Thanks @deleonio for providing more information on this, I will take a look!
from stencil.
Hey @deleonio 👋
I've identified that our recent update of glob has caused this issue, in particular the part where it imports node internals:
(left new vs right older version of glob bundled in Stencil)
It seems that this conflicts with running tests in Jest v26. Is there any reason you are on this particular Jest version and are unable to update? Updating Jest to the latest version has fixed the problem for me using your reproduction case.
from stencil.
Hey @deleonio 👋
I've identified that our recent update of glob has caused this issue, in particular the part where it imports node internals:
_(left new vs right older version of glob bundled in Stencil)_It seems that this conflicts with running tests in Jest v26. Is there any reason you are on this particular Jest version and are unable to update? Updating Jest to the latest version has fixed the problem for me using your reproduction case.
We always try to switch to the latest versions. With Jest, we have never managed to upgrade from 26.
We will try again.
from stencil.
Hey,
first I tried to upgrade jest again (public-ui/kolibri#6460).
Next I will check you provided npm package stencil/[email protected]
. - https://github.com/public-ui/kolibri/pull/6460/files
from stencil.
@deleonio I have a dev build for you with a fix. Yoi can install it via
npm i @stencil/[email protected]
. I recommend to update Jest to avoid these types of compatibility issues moving on.
👍 our pipeline passed! public-ui/kolibri#6460 THX!
from stencil.
Related Issues (20)
- bug: child input element is receiving un-wanted props HOT 12
- bug: watchIgnoredRegex is not respected during `stencil build --watch` HOT 2
- bug: puppeteer: piercing on level 1 breaks HOT 8
- bug: `autofocus` prop/attr is defined on other HTML attribute types instead of `HTMLAttributes` HOT 2
- bug: HOT 6
- bug: missing root element's scope id as classname in user provided children HOT 2
- Attribute ping is missing on AnchorHTMLAttributes HOT 3
- bug: Cannot read properties of undefined (reading 'isProxied') HOT 2
- bug: intermediate parents' scope ids are not reflected to the children elements HOT 3
- bug: Removing polyfills except for es5 builds breaks existing installs HOT 16
- bug: __mocks__ copied to output target HOT 3
- bug: Cannot access uninitialized variable, only in Safari, works with dev build HOT 3
- bug: Last version 4.18.2 breaks unit test in the proyect. HOT 9
- bug: Test files copied to output target HOT 8
- bug: When i try to integrate with react application, the slot element contains hidden attribute instead of displaying the content. Note: This stencil component is using scoped element. HOT 8
- feat: Style modes load styles only when needed HOT 1
- Stencil becomes a dependency to project when installing with --legacy-peer-deps HOT 4
- bug: unable to compile using angular's standalone mode (2) HOT 1
- bug: exception in an async componentWillLoad method will break the rendering cycle HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stencil.