GithubHelp home page GithubHelp logo

Comments (4)

pedro-andrade-inpe avatar pedro-andrade-inpe commented on July 28, 2024

@rafapereirabr, do you agree with these changes?

from gtfs2gps.

rafapereirabr avatar rafapereirabr commented on July 28, 2024

I like changing the function name to gtfs2gps(). Regarding the week_days argument, I think it makes sense to make this option available because service levels vary dramatically between weekdays and weekends. If we remove this argument, than our emission estimates latter on will affected by this info. What do you think?

from gtfs2gps.

pedro-andrade-inpe avatar pedro-andrade-inpe commented on July 28, 2024

I only do not like having an argument that simply calls a function that already belongs to the package, meaning that there are two ways of doing the same task. What do you think about allowing the first argument of gtfs2gps() to be a GTFS list with data.tables (in addition to a file name). The user could then do something as follows:

result <- read_gtfs("myfile.zip") %>%
    filter_week_days() %>%
    gtfs2gps() 

from gtfs2gps.

rafapereirabr avatar rafapereirabr commented on July 28, 2024

That would be fine. This would require changing the type of the input passed to gtfs2gps(). As it stands, the input is a zipped GTFS file ("myfile.zip"). We would only need to change this to a GTFS list with data.tables (the output from read_gtfs()

from gtfs2gps.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.