GithubHelp home page GithubHelp logo

Comments (7)

bcomnes avatar bcomnes commented on May 30, 2024

I noticed this last night. Does it spawn immediately on import? That might be holding the event loop open.

from js-ipfsd-ctl.

victorb avatar victorb commented on May 30, 2024

Oh, this is quite a horrible one. Anyone have an idea of why, so there is starting point for people wanting to help out?

from js-ipfsd-ctl.

bcomnes avatar bcomnes commented on May 30, 2024

@victorbjelkholm I would double check when the child process spawns. I belive that will hold the event loop open until the child process returns or is killed. See https://nodejs.org/api/child_process.html#child_process_child_process_spawn_command_args_options for more info on child process's spawn feature.

from js-ipfsd-ctl.

jbenet avatar jbenet commented on May 30, 2024

@bcomnes best use of that gif i've ever seen.

Is this in using subcomandante? there may be something wrong there-- it shoudn't hold the event loop.

from js-ipfsd-ctl.

daviddias avatar daviddias commented on May 30, 2024

Is this still a issue? I've used for other projects and it has been working fine, can you check @mappum @bcomnes ?

from js-ipfsd-ctl.

mappum avatar mappum commented on May 30, 2024

@diasdavid Yes, it's still an issue in 0.5.4.

from js-ipfsd-ctl.

dignifiedquire avatar dignifiedquire commented on May 30, 2024

The reason for this is the usage of https://github.com/rynti/node-shutdown-handler/blob/master/shutdown-handler.js. Looking at the code this does not look like to be a good idea to use :(

from js-ipfsd-ctl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.