Comments (12)
Have we got a test example?
from iplug2.
if you pGraphics->AttachCornerResizer(kUIResizerScale);
and
#if 1
for (auto i = 0; i < nRows * nColumns; i++) {
pGraphics->AttachControl(new IBKnobControl(*this, bounds.GetGridCell(cellIdx++, nRows, nColumns).GetPadded(-5.), bitmap1, kGain));
}
#endif
in IPlugEffect...
towards the end of the gif, you can see a line appear around the dirty area
from iplug2.
more obvious on virtualcz. seems to be bitmap related
from iplug2.
I see it on the second example but not the first. Is virtualCZ scaled when it happens, or just at normal size?
from iplug2.
Oh - I see it on the top one, but the bitmaps shouldn't be drawing anywhere near that should they? I'll take a look.
from iplug2.
Yes, it's only when scaled that a thin line appears around the dirty area. here is a better video of IPlugEffect:
from iplug2.
OK - I have some traction on this, but one issue is that in IRECT there are Scale() and ScaleBounds().
The first of these rounds - the second increases outwards. There is also PixelAlign (increase outwards).
In my opinion Scale() shouldn't round to integer values and ScaleBounds() shouldn't exist, although I could make ScaleAlign() which would call Scale() and the then PixelAlign() for convenience.
Not sure what the effects of this will be, but I had seen it before and it doesn't look right.
from iplug2.
Interestingly the same thing happens with IGraphicsCanvas, when you rescale
from iplug2.
graphics-edge-effects branch doesn't fix this unfortunately
from iplug2.
I know - that was the branch where I was going to put it, but I was mostly experimenting. What got pushed there was some niceifying but not the real deal which needs to be done soon!
from iplug2.
Fixed on graphics-edge-effects branch
from iplug2.
Fixed by 6baa706
from iplug2.
Related Issues (20)
- iOS: UITableViewPopup menu bounds should be based on content
- MacOS OpenGLContext leaks ~4MB on window close HOT 1
- WebUI example crashes when double-clicked HOT 4
- IMidiMsg.mOffset HOT 1
- ShowMessageBox mixes up message and caption on mac HOT 2
- Missing color search info the background of IVControls HOT 1
- IOS App plugin never gets deconstructed HOT 5
- Strange behavior IGraphics::Resize in Kushview Element (Windows, VST3)
- Skia METAL bitmap colours appear incorrect HOT 4
- Macos OpenGL: multiple instances clash
- Dropping const qualifier in IGraphics/Platforms/IGraphicsWin
- [CMake branch] Clang support on windows HOT 1
- CMakeLists for Examples/IPlugWebUI HOT 1
- MIDI velocity values get rounded incorrectly HOT 1
- IGraphicsSkia::GetLayerBitmapData() crashes in iOS AUv3 HOT 1
- iPlug2 doesn't compile on windows in 32-bit due to missing macros
- AUv2 hosts reporting negative ppq becomes -1 in iPlug
- Add DirtyState()/Rework DirtyParametersFromUI()
- Unable to get raw name for Unknown host HOT 1
- CLAP: PLUG_CHANNEL_IO "1-1 2-2" does not work in Reaper
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from iplug2.