GithubHelp home page GithubHelp logo

Comments (5)

iqbal-lab avatar iqbal-lab commented on August 14, 2024

Here is the test

`
TEST(BackwardSearchTest, Multiple_matches_over_multiple_sites){

//prg=acgacacat5gatag6tagga6gctcg6gctct5gctcgtgataatgactagatagatag7cga8cgc8tga8tgc7taggcaacatctacga                                                                       
test_file2="../test_cases/multiple_matches_multiple_sites.txt";
//read aligns over allele 1 of site 5, the nonvariableregion and allele 3 of site 7                                                                                       
query="tgata";

`
After running the backward search, this is what sites looks like

`
(gdb) p sites
$1 = std::list = {[0] = std::vector of length 0, capacity 0, [1] = std::vector of length 1, capacity 100 = {{first = 7, second = std::vector of length 0, capacity 0}}, [2] = std::vector of length 1, capacity 100 = {{first = 5, second = std::vector of length 1, capacity 1 = {1}}}}

`

So we correctly see 7 first, and fail to spot the overlap with allele 3, because it does not cross the 5 - so it's correct/expected behavious to have this {{first = 7, second = std::vector of length 0, capacity 0}}.

This is also correct, and correctly after the 7
{{first = 5, second = std::vector of length 1, capacity 1 = {1}}

I just wasn't expecting this at the front:
[0] = std::vector of length 0, capacity 0,

from gramtools.

iqbal-lab avatar iqbal-lab commented on August 14, 2024

Need to read the code - in fact if I spent the time reading the code not bug-raising - er - I might have to go away from the computer and forget what i was doing

from gramtools.

iqbal-lab avatar iqbal-lab commented on August 14, 2024

This is idiocy on my part. Fixing.

from gramtools.

iqbal-lab avatar iqbal-lab commented on August 14, 2024

Fixed. I forgot there was a match in the nonvariable region, and anyway my test code was wrong. test passes now.

from gramtools.

iqbal-lab avatar iqbal-lab commented on August 14, 2024

Wow, github clever enough to auto close this bug on the basis of the comment on that commit!!!

from gramtools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.