GithubHelp home page GithubHelp logo

Comments (5)

jonnywilliamson avatar jonnywilliamson commented on August 25, 2024

Good point. I wondered about this a few months ago.

@irazasyed - any reason why we use GET requests instead of POST requests when connecting to the telegram server?

I had a look and try to change the normal GET to POST in the code, but I wasn't sure how to set the parameters to application/x-www-form-urlencoded so I wasn't successful.

from telegram-bot-sdk.

jonnywilliamson avatar jonnywilliamson commented on August 25, 2024

Actually I just worked it out.

If we change the $this->get to a $this->post in any of the send methods on the API, we have to add a form_params to the parameters.

This could be refactored, but a quick hack at the moment would look like this:

// Api.php

    /**
     * Send text messages.
     *
     * @link https://core.telegram.org/bots/api#sendmessage
     *
     * @param int    $chat_id
     * @param string $text
     * @param bool   $disable_web_page_preview
     * @param int    $reply_to_message_id
     * @param string $reply_markup
     *
     * @return Message
     */
    public function sendMessage(
        $chat_id,
        $text,
        $disable_web_page_preview = false,
        $reply_to_message_id = null,
        $reply_markup = null
    ) {
        $params = compact('chat_id', 'text', 'disable_web_page_preview', 'reply_to_message_id', 'reply_markup');
        $response = $this->post('sendMessage', ['form_params' => $params]);

        return new Message($response->getDecodedBody());
    }

from telegram-bot-sdk.

Ham3D avatar Ham3D commented on August 25, 2024

it seems working , send a Pr

from telegram-bot-sdk.

irazasyed avatar irazasyed commented on August 25, 2024

Please open a new PR and I can merge it. I won't be able to work on this until this month end. So either someone send a PR or please wait. Thanks!!

from telegram-bot-sdk.

jonnywilliamson avatar jonnywilliamson commented on August 25, 2024

#40 Refers

from telegram-bot-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.