Broken in FF, How do you run tests? about browser-request

[jonpacker]

+1, this is causing problems for me also.

[max-mapper]

@jhs if you add me as a collabo to this repo i'll fix junk

[jhs]

@maxogden Thanks very much!

I believe you already have access, since you are a member of the iriscouch/colleagues group. Please let me know if that is only read-only or something like that.

[max-mapper]

OH!

On Fri, Jul 5, 2013 at 5:04 PM, Jason Smith [email protected]:

@maxogden https://github.com/maxogden Thanks very much!

I believe you already have access, since you are a member of the
iriscouch/colleagues group. Please let me know if that is only read-only or
something like that.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/12#issuecomment-20544448
.

[max-mapper]

I fixed this by changing the line in XMLHTTPRequest from:

var XHR = xmlhttprequest.XMLHttpRequest

to

var XHR = xmlhttprequest.XMLHttpRequest || XMLHttpRequest

but there are issues:

• the submodule for xmlhttprequest in this repo is old and needs to be updated
• I don't know how to run the tests
• I don't know how to build a new version of the library

it would be nice if npm test and npm run build were implemented to do these

[jhs]

I fixed the submodule. Building is now available via npm run build.

The tests require CouchDB running on localhost:5984. Me, I would rather go out in public with no pants on than not have couch at localhost:5984; but perhaps that is not a broadly-held opinion.

@maxogden what is your sense of Ender? Are people using it anymore? Is it worth continued support? It was the dog's bollocks when I wrote this but I don't follow browser JS trends much. Thanks.

[max-mapper]

im pretty sure nobody uses ender anymore

On Sat, Jul 6, 2013 at 5:59 PM, Jason Smith [email protected]:

I fixed the submodule. Building is now available via npm run build.

The tests require CouchDB running on localhost:5984. Me, I would rather go
out in public with no pants on than not have couch at localhost:5984; but
perhaps that is not a broadly-held opinion.

@maxogden https://github.com/maxogden what is your sense of Ender? Are
people using it anymore? Is it worth continued support? It was the dog's
bollocks when I wrote this but I don't follow browser JS trends much.
Thanks.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/12#issuecomment-20563758
.

[jhs]

Thanks. Also, if var XHR = xmlhttprequest.XMLHttpRequest fails then that is a bug in my building or packaging. The intention is that xmlhttprequest is a global variable (or that it is correctly in browserify, etc.)

The whole point of using the xmlhttprequest project as a submodule is that it standardizes the API and behavior across all browsers.

[kirbysayshi]

Glad to see that progress is being made on this.

Note: I am one of many (I assume) who would rather go into public without pants than require a local couchdb server for a JS library's tests.

[jhs]

We will have to agree to disagree that CouchDB provides a feeling of warmth, comfort, and security.

I respect your opinion, and I support diversity; so I will work on removing couch as a test dependency. Really, all that is needed is a static file server, which Node itself can do.

[kirbysayshi]

That sounds like a good plan, especially if all that is required is to be able to serve static files. There are several modules that will do that (quickserve, serve, paperboy...).

Also, I have nothing against couchdb! Only that an external tech is a impediment to others contributing.

[max-mapper]

@jhs i'm pretty sure that something about the way you're loading the xmlhttprequest polyfill is broken because I cant get it to work in firefox without adding || XMLHttpRequest to the end like I said above

[max-mapper]

ok I have a pretty radical fork https://github.com/maxogden/browser-request

on the plus side it has testling tests

[max-mapper]

@jhs do you approve of my house cleaning here?

[indexzero]

+1 I'm not a browser expert these days, but "browserify ftw" seems like a good approach!

[max-mapper]

made a pull req #17

[paulmelnikow]

This still seems to be a problem in the latest version from npm (0.2.1). Works in Chrome, but not in Firefox.