GithubHelp home page GithubHelp logo

Comments (3)

trel avatar trel commented on June 24, 2024

two additional options...

  1. would it be better/easier to have the first NUL of a string of bytestring not be made so important?
    or
  2. have the bytesBuf_t always 'self heal' and make it automatically have the correct length based on its content?

from irods_rule_engine_plugin_python.

d-w-moore avatar d-w-moore commented on June 24, 2024

bytesBuf_t appears to already do the right thing, but the difficulty we have in the Python RE plugin is the inability to set its content (absent this modification) If we consider these two implementations of a rule to write from a local file into a data object (adapted from here ):

def py_obj_write_1(args,callback,rei):
    dest_file = args[0]
    with open('/tmp/file.tar.gz', 'rb') as file_:
        binarycontent = (file_.read())
        ret_val = callback.msiDataObjOpen(('objPath={}++++openFlags=O_WRONLY''O_CREAT''O_TRUNC').format( dest_file), 0)
        f = ret_val['arguments'][1]
        callback.msiDataObjWrite(f, binarycontent, len(binarycontent))
        callback.msiDataObjClose(f, 0)

def py_obj_write_2(args,callback,rei):
    dest_file = args[0]
    with open('/tmp/file.tar.gz', 'rb') as file_:
        binarycontent = (file_.read())
        b = BytesBuf()
        b.setbuf(binarycontent, len(binarycontent))
        ret_val = callback.msiDataObjOpen(('objPath={}++++openFlags=O_WRONLY''O_CREAT''O_TRUNC').format( dest_file), 0)
        f = ret_val['arguments'][1]
        callback.msiDataObjWrite(f, b, b.len)
        callback.msiDataObjClose(f, 0)

The first attempts the write with a string as the buffer, which Python can handle even with NULs, but the plugin seems to translate it as const char* . So if there's a NUL in the string, then regardless of specifying the length param in the msiDataObjWrite, the whole buffer never makes it into the microservice. The BytesBuf_t is the proper solution, but the Python plugin even in its latest release doesn't actually let you set the content; it only allows you to instantiate a blank object with no content.

from irods_rule_engine_plugin_python.

trel avatar trel commented on June 24, 2024

Right, so setbuf appears to be the answer.

And the __del__ feels correct as well. The tests will let us know if it creates a double-free anywhere, but I'd be surprised.

from irods_rule_engine_plugin_python.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.