Invalid pointer free when error occurs inside of callback.msiSetKeyValuePairsToObj about irods_rule_engine_plugin_python

[trel]

The clearMsParam() fixes the 32k leak - so we want to keep it. It allows for multiple rules to be run within the same connection without making the server leak until collapse.

So, wrapping line 278 in some logic to detect whether we're already 'in an error case' would prevent this pointer free.

More investigation to whether that means that a leak would still occur, but maybe that doesn't matter since it's already in an exception case.

Another consideration is when !retVal.ok() but when not caused by an exception (just a regular iRODS error code).

If an exception is thrown, but caught and handled in the rule itself... how would this behave?

@stsnel, I think we can get this done pretty quickly for a 4.2.11.1.

[alanking]

We have confirmed that the solution works and prevents leaks for non-error cases.

I did notice that some microservices still leak and we will try to address this in the next server release in addition to the other observed leaks. See irods/irods#6044 and irods/irods#6108

[stsnel]

@trel Thank you, that sounds like a great solution 👍