Comments (18)
I believe this is resolved. Can others verify?
from github.
I think they used replaceState on purpose, so the lots of tab changes don't stack up in the history. It took me a while to get used to that, but I find it very unlikely that they would change that behaviour, considering the drawback.
from github.
What's the drawback? Accessibility?
from github.
I think the idea is this: You look at a PR and do a lot of switching between the three tabs. With pushState, they would pile up as history entries. To then go back, you'd have to use the back button for each of those. Since the tabs don't look like links, the user might expect the back button to lead them back to the previous page instantly.
Both approaches seem valid to me, so its more of a design decision then a bug.
from github.
What usually happens for me is that I click a tab, then then press the cmd-[
keyboard command to go back, end up at the list of pull requests, curse loudly, press cmd-]
to go forward to the pull request page, only to see the same tab I already was trying to get back from, curse again, then laboriously drag my mouse over to the tab and explicitly click it.
Almost the whole page changes. There's no excuse for it not being a history entry.
from github.
👍
from github.
This bites me every damn day.
from github.
Ditto. EVERY day. I would have thought something pavlovian would have clicked by now in my brain...
from github.
Show me someone who thinks it's better the way that it is, and I'll show you someone who doesn't use github issues.
from github.
👍
from github.
+1
from github.
👍 This bites me all the time.
from github.
What usually happens for me is that I click a tab, then then press the cmd-[ keyboard command to go back, end up at the list of pull requests, curse loudly, press cmd-] to go forward to the pull request page, only to see the same tab I already was trying to get back from, curse again, then laboriously drag my mouse over to the tab and explicitly click it.
This! Drives me nuts too.
from github.
💯 👍
from github.
@marcomorain Please note this project is not an official channel for Github issues. If you agree with this issue, read and follow the instructions in the project README: send a message to Github Support, and report back in comments on this issue with a relevant excerpt of your message and Github's response.
Edit: Just realized I never posted my interaction with Github.
Sent to Github support:
Steps to reproduce problem:
- Open pull requests
- Navigate to a specific pull request
- Navigate to Files Changed tab
- Click back button or type Command+[ to navigate backward
- Land on pull requests page instead of PR conversation tab.
- Curse loudly.
- Navigate forward again
- Scroll to top.
- Click conversation tab.
I've been using Github on a daily basis for a year and this one still bites me every time.
See #3
Response:
Thanks for writing in, I'll definitely pass your +1 for that feature on to the team to consider. Let me know if there's anything else I can help you with!
from github.
I can confirm that clicking back on the commits page does take you back one page rather than 2.
from github.
I don't think this issue applies anymore. I go back to the conversation tab when I click back.
from github.
There is however another issue similar to this one that hasn't been fixed: #1464
from github.
Related Issues (20)
- Auto-summary of markdown files is not indented anymore? HOT 1
- Github Arctic Code Vault Contributor HOT 2
- Sorting git code repository HOT 7
- Ease of switching between bulleted and numbered lists HOT 2
- Image as hyperlink doesn't work in GitHub's render of .ipynb file HOT 2
- Internal Server Error - Seems to have happened before
- Let's check this!! HOT 2
- "Files changed" not cleared when navigating to Code / Issues / Pull requests HOT 2
- Automatic Issue Linking not working HOT 5
- Web UI Deletion HOT 2
- Cannot remove accidentally assigned pull request reviewer HOT 2
- Visual studio icon in Code menu HOT 2
- Allow .age attachments to issues HOT 4
- Add threading for comments made directly on a Pull Request HOT 2
- A little UI bug on GitHub HOT 2
- Allow me to edit comments of blocked users as a repo owner just like I can already edit issues HOT 1
- Cannot change the base branch of a pull request to a particular branch HOT 1
- test HOT 1
- 📣 [NOTICE] This repo is being deprecated HOT 3
- test issue HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from github.