Comments (29)
Okay, I updated my Podfile to:
pod 'RMessage', :git => 'https://github.com/donileo/RMessage.git', :branch => '2.x.x_develop'
updated, ran and all good! Thank you!
from rmessage.
@tylerwilson Thanks for the bug report. Will put out a 2.3.4 release sometime soon today or tommorrow hopefully.
from rmessage.
Will look into this today. Hopefully its something I can reproduce.
from rmessage.
Well, I can't reproduce it as I have 2 different iPads (one iPad mini and one iPad Air), and on both of them it works fine, it's very occasional I get feedback with this error, so I don't really get it. I am using Pod's in my project, so I should have the latest version..
from rmessage.
@martin072 Can you pull develop and tell me if it fixes anything, even though I'm not expecting it to. Something I forgot to ask is what version of RMessage are you using? Based on your error message it seems your are using the 2.3.x version. There isn't any nib named RMessageView in the 3.x.x Swift version.
from rmessage.
@donileo, the app is in a production state, pulling a developer version and releasing it would be a bit risky for me, further more it seems to be some isolated issues only, not at all reproducible..
I am using Pods, this was the output of the latest build:
RMessage (2.3.2):
- HexColors (~> 4.0)
- PPTopMostController
(my project is in Objective C)
Hope this helps
from rmessage.
Hello,
I've come across this issue too.
I'm able to reproduce the issue when turning off mobile data and wifi.
It occurs when I call:
[ErrorMessage showConnectionError:self.navigationController
errorMessage:errorMessage
errorCode:errorCode
refreshMethod:]
It falls over in RMessageView.m, Line 269:
self = [[NSBundle bundleForClass:[self class]] loadNibNamed:NSStringFromClass([self class]) owner:self options:nil].firstObject;
Using on iPhone XR running iOS 13.3.
Hope it helps.
Thanks
from rmessage.
Made some changes that I believe fix these issues. Commit for the change is 9118805. Please pull 2.x.x_develop
and test. If all seems ok I will go ahead and put out a 2.3.3 release. I haven't tested if these issues affect the 3.x.x series but will test that a bit later.
If you have issues testing these changes since I have not actually put out a new 2.3.3
Pod release please pull 2.x.x_develop
, copy the RMessage Folder from it to your project and then use pod 'RMessage', :path => '<path to copied RMessage folder>'
in your Podfile
instead of what you have now to test the changes.
from rmessage.
Just released a new version (2.3.3) via Pod; easier to test the fix now.
from rmessage.
I just did a pod update and it went to version 2.3.3. and when I ran I got the following crash:
*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Could not read RMessage config file from main bundle with name RMessageDefaultDesign.json'
*** First throw call stack:
(
0 CoreFoundation 0x00007fff23e3cf0e __exceptionPreprocess + 350
1 libobjc.A.dylib 0x00007fff50ba89b2 objc_exception_throw + 48
2 CoreFoundation 0x00007fff23e3cc88 +[NSException raise:format:arguments:] + 88
3 Foundation 0x00007fff258b8bd2 -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 191
4 RMessage 0x000000010a48503e +[RMessageView setupGlobalDesignDictionary] + 494
5 RMessage 0x000000010a4853ab +[RMessageView addDesignsFromFileWithName:inBundle:] + 107
6 RMessage 0x000000010a4841b5 +[RMessage addDesignsFromFileWithName:inBundle:] + 101
7 Salonbiz Book 0x0000000104caa057 -[HomeViewController viewDidLoad] + 263
as seen I am calling the following method for it to read my custom RMessageDesigns.json:
[RMessage addDesignsFromFileWithName:@"RMessageDesigns" inBundle:NSBundle.mainBundle];
Thought you should know. I reverted to 2.3.2 and working again.BTW, I would love to use the 3.x series, but this app still has to support iOS 9.x. Hey, I don't like it either. :-(
from rmessage.
Can you please clean your build directory and your derived data and see if this happens?. I am not seeing that error message when building with latest Xcode on my end.
RMessageDefaultDesign.json
is now part of RMessage's bundle which is one of the code changes that was committed. Given your error implies its not part of RMessage's bundle tells me your build is probably dirty somehow..
from rmessage.
Okay, cleaning did not work. But I did debug the code, and one issue is here: in 2.3.3 a static RMessageBundle property was added, but the init code fails to locate it properly. It fails on this line:
NSURL *resourceBundleURL = [appBundle URLForResource:@"RMessage" withExtension:@"bundle"];
which then cause the lookup for the default json file to fail and then crash when trying to read.
in 2.3.2 it used a simple [NSBundle [self class]] which appears to work fine. I can debug further if you like, but for now i will be using 2.3.2.
from rmessage.
Side question: what would be the possibility of lowering the iOS version requirement of RMessage 3.0 down to iOS 9.3? Are there iOS 11 specific features it is using?
from rmessage.
Lowering the requirement after its been declared for the 3.0 series isn't going to happen. That would be breaking the contract as far as what has already been declared for that release. The real issue is fixing this problem which is tedious on my end because I can't reproduce. On my end it works correctly on the latest Xcode 11 and iOS 13.5 runtime. I tried downgrading to Xcode 9/iOS 7.0 runtime isn't supported by Mac OS Catalina and I don't have a separate machine to run that on. I'll see if I can somehow run on iOS 9 runtime and see if I can catch the issue you are seeing.
Update: Yea, it seems Catalina dropped support for iOS 9 simulators. If someone other than @tylerwilson can somehow test on iOS 9 and iOS 7 and report back if this issue exists for them, it would be helpful at least in knowing if the issue is reproducible. If it is I'll still have to come up with a way to reproduce it myself somehow.
from rmessage.
FYI, I am running with Xcode 11.5 on an iPad 13.5 simulator. So not an issue with iOS 9..
from rmessage.
Ok, can you try the RMessage demo target and see if you get the crash there? Just run the demo and hit a couple of buttons and see if they show. If this issue is specific to integrating RMessage via a Pod then maybe that’s where I can reproduce.
from rmessage.
Ok, so just tested on a brand new Xcode 11.1 project with iPhone SE2 simulator, brought in RMessage 2.3.3 using Cocoapods. Using a RMessageDesigns.json file in my main app bundle via [RMessage addDesignsFromFileWithName:@"RMessageDesigns" inBundle:NSBundle.mainBundle];
. Works perfectly on my end.
from rmessage.
Just to be sure, you included:
use_frameworks!
in your Podfile?
I narrowed it down to this line:
NSBundle *appBundle = [NSBundle mainBundle];
which returns my main .app and so the next URLForResource will fail, since the resource is not a child. If I instead change that line to:
NSBundle *appBundle = [NSBundle bundleForClass:[self class]];
then everything works as expected. Thanks!
from rmessage.
Ahh. That’s definitely the problem. Please see CocoaPods/CocoaPods#3226. Its weird that for me even without making any change and doing use_frameworks! it still works.
from rmessage.
Great. Look forward to it. :-)
from rmessage.
@tylerwilson Ok can you point your RMessage pod to 2.x.x_develop branch now and retest? Make sure to clean your build directories if possible. Also, what actual XCode version are you using to build your app?
from rmessage.
2.3.4 Release is now on Cocoapods.
from rmessage.
Verified that all is working for me now with 2.3.4. Thank you!
from rmessage.
Closing this issue out as I believe it is fixed.
from rmessage.
Hi, I still see the errors with 2.3.4.. Many app crashes with the following debug info:
Could not load NIB in bundle: 'NSBundle (not yet loaded)' with name 'RMessageView'
-or-
Could not load NIB in bundle: 'NSBundle (loaded)' with name 'fwX-4r-u7q-view-Y9P-0D-SwC' and directory 'Main.storyboardc'
from rmessage.
@martin072 What iOS version are you testing with?
from rmessage.
I am receiving crash reports from various users. All of them are iOS 14.x with the most recent report for iOS 14.3
I don’t know if it helps, but my project is in Objective C
from rmessage.
Can you reproduce the crashes yourself if you run on a fresh project with iOS14?
from rmessage.
No, that is the issue. It works fine on all my tests and devices. It’s just that some users report the app crashes. Totally random. I am not able to reproduce it.
from rmessage.
Related Issues (20)
- blur effect not working in ios 11? HOT 9
- How to add attributedString in the subtitle? HOT 3
- Set icon color in custom designs JSON HOT 5
- RMessagePositionTop displaying not correctly when double height status bar HOT 5
- [Issue] [iPhone X] Notification banner is too short, doesn't extend down far enough to display title. HOT 20
- How to reset all queued messages and the displayed view? HOT 3
- notification showing several times HOT 4
- Display issues in UITableViewController on iOS 10 HOT 14
- Title and Subtitle with Custom Font HOT 10
- Crash HOT 3
- Infinite loop when using automatic presentationViewController detection HOT 3
- Could not load NIB in bundle: NSBundle HOT 1
- Assets are not shown on the default presets HOT 1
- Demo project doesn't compile; downloaded as zip file HOT 2
- May I ask you to add a 2.3.x release of Carthage? HOT 1
- Crashing the app in iOS 13. HOT 3
- Possible to animate title/body text? HOT 5
- Swift 5 compatibility - Apple silicion M1 chip HOT 5
- 'characters' is unavailable: Please use String directly
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rmessage.