GithubHelp home page GithubHelp logo

In Chrome if user selects the "Remember my choice for all links of this type" check box the fail callback always gets called. about custom-protocol-detection HOT 6 CLOSED

ismailhabib avatar ismailhabib commented on July 18, 2024
In Chrome if user selects the "Remember my choice for all links of this type" check box the fail callback always gets called.

from custom-protocol-detection.

Comments (6)

ismailhabib avatar ismailhabib commented on July 18, 2024

Hi spstratis, thanks for the feedback!

You are absolutely right, this Chrome implementation is based on the assumption that there will be app loaded by the custom protocol handler and thus will steal the focus from the window. Could you tell me what the behavior of your protocol handler in this case?

from custom-protocol-detection.

spstratis avatar spstratis commented on July 18, 2024

For me the protocol handler is opening a windows app. It opens it successfully yet the fail call back still fires off as if focus is not being put on to the app the is opening.

from custom-protocol-detection.

ismailhabib avatar ismailhabib commented on July 18, 2024

That sounds strange. Could you do a bit more debugging to see whether the onBlur method is being triggered at all? One possibility is that the app is slow to load (need more than a second) or the loaded app doesn't take the focus at all.

from custom-protocol-detection.

spstratis avatar spstratis commented on July 18, 2024

Yea I was thinking of adding additional time to the timeout and checking to see if that makes a difference. I'll let you know the result of some additional debugging.

from custom-protocol-detection.

spstratis avatar spstratis commented on July 18, 2024

So far it looks like setting the time out to 2000 takes care of the issue.

from custom-protocol-detection.

spstratis avatar spstratis commented on July 18, 2024

You were right the loaded app was not taking focus. I notice from time to time it will still hit the failure state but I believe that may be due to propagation on the button click to launch the app. You should feel free to close this defect. Thanks for responding back!

from custom-protocol-detection.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.