GithubHelp home page GithubHelp logo

Comments (6)

ItalyPaleAle avatar ItalyPaleAle commented on July 19, 2024

Good point. I think that with situations like Webpack, svelte, etc, the line line between dependencies and devDependencies isn’t always clear. There certainly are situations where svelte should be included as a “production” dependency.

How about we give it as an option and let the user decide based on their situation? Feel free to submit a PR :)

from svelte-spa-router.

longrunningprocess avatar longrunningprocess commented on July 19, 2024

I'm not aware of those situations where one would need Svelte as a production dependency, my understanding is that it was used during the build process and then you were left with plain old javascript, no svelte...but I'm new to it and will take your word for it.

I'll submit the PR shortly for the change I'm suggesting.

Thanks!

from svelte-spa-router.

ItalyPaleAle avatar ItalyPaleAle commented on July 19, 2024

One example is when you build an app that has both front-end and back-end. The “start” script usually rebuilds the front end too. In this case, you might want to put svelte as a prod dependency.

from svelte-spa-router.

longrunningprocess avatar longrunningprocess commented on July 19, 2024

oh ok, I could see that. Here's the only suggestion I'm making: #11

Thanks for considering!

from svelte-spa-router.

ItalyPaleAle avatar ItalyPaleAle commented on July 19, 2024

Ok so I've been thinking about this for the last while and I believe I'd actually prefer to remove --save from the command.

  1. People will likely have a preference on whether they want to save this as a dependency or devDependency. It depends on how their app is built, on their preference, and on whatever other reason. I expect developers at this point to be at least familiar enough with NPM to make this decision on their own and I shouldn't be spoon-feeding them!
  2. Recent versions of NPM save packages in the package.json file (if present) by default, so actually --save is redundant.

I'm going to make the change and close the PR and the issue. Regardless, I'd like to thank you for bringing this to my attention and sparking a good conversation and giving me the opportunity to think about it 😄

from svelte-spa-router.

longrunningprocess avatar longrunningprocess commented on July 19, 2024

Nice chatting with you, appreciate your responsiveness.

from svelte-spa-router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.