Comments (6)
Good point. I think that with situations like Webpack, svelte, etc, the line line between dependencies and devDependencies isn’t always clear. There certainly are situations where svelte should be included as a “production” dependency.
How about we give it as an option and let the user decide based on their situation? Feel free to submit a PR :)
from svelte-spa-router.
I'm not aware of those situations where one would need Svelte as a production dependency, my understanding is that it was used during the build process and then you were left with plain old javascript, no svelte...but I'm new to it and will take your word for it.
I'll submit the PR shortly for the change I'm suggesting.
Thanks!
from svelte-spa-router.
One example is when you build an app that has both front-end and back-end. The “start” script usually rebuilds the front end too. In this case, you might want to put svelte as a prod dependency.
from svelte-spa-router.
oh ok, I could see that. Here's the only suggestion I'm making: #11
Thanks for considering!
from svelte-spa-router.
Ok so I've been thinking about this for the last while and I believe I'd actually prefer to remove --save
from the command.
- People will likely have a preference on whether they want to save this as a dependency or devDependency. It depends on how their app is built, on their preference, and on whatever other reason. I expect developers at this point to be at least familiar enough with NPM to make this decision on their own and I shouldn't be spoon-feeding them!
- Recent versions of NPM save packages in the package.json file (if present) by default, so actually
--save
is redundant.
I'm going to make the change and close the PR and the issue. Regardless, I'd like to thank you for bringing this to my attention and sparking a good conversation and giving me the opportunity to think about it 😄
from svelte-spa-router.
Nice chatting with you, appreciate your responsiveness.
from svelte-spa-router.
Related Issues (20)
- In vite, i can't use the proxy /dev HOT 1
- Redirection from route pre-condition HOT 5
- Nested routes as maps HOT 1
- If I want to go to the login page in the sidebar + SPA form, is it possible with route guard? HOT 4
- Is this not possible in routeLoaded? HOT 5
- What is the black bar in this image? HOT 2
- Feature request: Svelte 4 support HOT 13
- FEATURE REQUEST: pass next() in precondition to decide whether the router should *change* the current route HOT 1
- Load user data HOT 4
- How to check hash-bashed history HOT 1
- Is there an alternative to the "Failed to fetch dynamically import problem" issue in Vite + Svelte spa environment? HOT 1
- WARNING: The following packages have a svelte field in their package.json but no exports condition for svelte. [email protected] HOT 8
- Typescript problematic types after "wrapping" the route HOT 2
- navigating within same component does not work HOT 5
- Typescript support: Package path ./wrap is not exported from package svelte-spa-router HOT 2
- Will the library support Svelte 5? HOT 5
- Authentication and Authorization HOT 6
- Layouts not exists for svelte-spa-router? HOT 6
- Feature request: Nested route priority HOT 1
- children router bug HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from svelte-spa-router.